linux-kernel - [regression] bpf_local_storage.c:785:60: error: ‘kvmalloc_array_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0dd2457-ab58-1b08-caa4-93eaa2de221e@nerdbynature.de>
Date: Mon, 1 Jul 2024 22:56:22 +0200 (CEST)
From: Christian Kujau <lists@...dbynature.de>
To: linux-kernel@...r.kernel.org
cc: Martin KaFai Lau <martin.lau@...ux.dev>, 
    Alexei Starovoitov <ast@...nel.org>, 
    Daniel Borkmann <daniel@...earbox.net>, 
    Andrii Nakryiko <andrii@...nel.org>, Eduard Zingerman <eddyz87@...il.com>, 
    Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>, 
    John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, 
    Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>, 
    Jiri Olsa <jolsa@...nel.org>, regressions@...ts.linux.dev, 
    patchwork-bot+netdevbpf@...nel.org, peter.ujfalusi@...el.com
Subject: [regression] bpf_local_storage.c:785:60: error: ‘kvmalloc_array_node_noprof’ sizes specified with ‘sizeof’

This has been brought up before along with a patch[0] but has not been 
pushed to mainline:

 $ make allnoconfig
 $ enable CONFIG_WERROR and CONFIG_BPF
 $ make
 [...]
 kernel/bpf/bpf_local_storage.c: In function ‘bpf_local_storage_map_alloc’:
 kernel/bpf/bpf_local_storage.c:785:60: error: ‘kvmalloc_array_node_noprof’ sizes specified with ‘sizeof’ in the earlier 
   argument and not in the later argument [-Werror=calloc-transposed-args]
     785 |         smap->buckets = bpf_map_kvcalloc(&smap->map, sizeof(*smap->buckets),
         |                                                            ^

I always compile kernels with CONFIG_WERROR=y and I'm surprised that this 
has not been caught by any build bots yet (or I did not see those 
reports), the help text even says "If in doubt, say Y", so I'm very 
puzzled why almost nobody else would be affected by this. The compilation 
error happens on a Fedora 40 laptop, with gcc 14.1.1 20240620 (Red Hat 
14.1.1-6) installed.

The fix posted in [0] does fix the compilation errors, but maybe never 
made it to the correct trees to be included upstream? We are already in 
-rc6 and I fear that the next release will be shipped with that problem.

Thanks,
Christian.

[0] https://lore.kernel.org/bpf/363ad8d1-a2d2-4fca-b66a-3d838eb5def9@intel.com/T/
-- 
BOFH excuse #424:

operation failed because: there is no message for this error (#1014)
Download attachment "config_error.txt.gz" of type "application/gzip" (9149 bytes)