linux-kernel - Re: [PATCH] watchdog: Add missing include for FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 1 Jul 2024 14:41:47 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Matti Vaittinen <mazziesaccount@...il.com>,
 Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] watchdog: Add missing include for FIELD_*()

On 7/1/24 00:56, Matti Vaittinen wrote:
> The FIELD_PREP() and FIELD_GET() macros are defined in the
> linux/bitfield.h. Include this header to avoid missing the macro
> definitions.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406300817.hcJ9VtLf-lkp@intel.com/
> 

Acked-by: Guenter Roeck <linux@...ck-us.net>

> ---
> This patch is built on the ib-mfd-regulator-watchdog-v6.11 tag.
> These macros got included via some indirect route in my build
> config on v6.10-rc1 - but the lkp reported problem on some config.
> 
> Please, let me know if this follow-up fix is Ok or if I should rather
> respin the:
> https://lore.kernel.org/all/20240627082555.GH2532839@google.com/
> with this fix. (I don't see much of potential bisecting problems if this
> fix still gets in the next release, as the watchdog code is behind a new
> Kconfig flag - but please let me know if I should re-spin whole series).
> ---
>   drivers/watchdog/bd96801_wdt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/bd96801_wdt.c b/drivers/watchdog/bd96801_wdt.c
> index ff51f42ced2a..12b74fd2bc05 100644
> --- a/drivers/watchdog/bd96801_wdt.c
> +++ b/drivers/watchdog/bd96801_wdt.c
> @@ -5,6 +5,7 @@
>    * ROHM BD96801 watchdog driver
>    */
>   
> +#include <linux/bitfield.h>
>   #include <linux/interrupt.h>
>   #include <linux/kernel.h>
>   #include <linux/mfd/rohm-bd96801.h>
> 
> base-commit: fcf1f960a6aa45a22efd4d49114c672ed305b85f