linux-kernel - Re: [PATCH] hwmon: (adt7475) Fix default duty on fan is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c91530f-00f3-44ed-ae77-312260c2af9e@roeck-us.net>
Date: Mon, 1 Jul 2024 15:45:49 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Wayne Tung <chineweff@...il.com>
Cc: jdelvare@...e.com, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (adt7475) Fix default duty on fan is disabled

On Mon, Jul 01, 2024 at 03:32:52PM +0800, Wayne Tung wrote:
> According to the comments on fan is disabled, we change to manual mode
> and set the duty cycle to 0.
> For setting the duty cycle part, the register is wrong. Fix it.
> 
> Signed-off-by: Wayne Tung <chineweff@...il.com>
> ---

Applied. 

Curious - how did you find that ? That bug existed since the driver was
introduced.

Thanks,
Guenter

>  drivers/hwmon/adt7475.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
> index 4224ffb30483..ec3336804720 100644
> --- a/drivers/hwmon/adt7475.c
> +++ b/drivers/hwmon/adt7475.c
> @@ -1900,7 +1900,7 @@ static void adt7475_read_pwm(struct i2c_client *client, int index)
>  		data->pwm[CONTROL][index] &= ~0xE0;
>  		data->pwm[CONTROL][index] |= (7 << 5);
>  
> -		i2c_smbus_write_byte_data(client, PWM_CONFIG_REG(index),
> +		i2c_smbus_write_byte_data(client, PWM_REG(index),
>  					  data->pwm[INPUT][index]);
>  
>  		i2c_smbus_write_byte_data(client, PWM_CONFIG_REG(index),