linux-kernel - [PATCH 5.10/5.15/6.1 1/1] staging: iio: resolver: ad2s1210: remove call to spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 2 Jul 2024 02:43:24 +0300
From: Aleksandr Mishin <amishin@...rgos.ru>
To: <stable@...r.kernel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Aleksandr Mishin <amishin@...rgos.ru>, Lars-Peter Clausen
	<lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Jonathan
 Cameron <jic23@...nel.org>, Graf Yang <graf.yang@...log.com>, Mike Frysinger
	<vapier@...too.org>, <linux-iio@...r.kernel.org>,
	<linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
	<lvc-project@...uxtesting.org>, David Lechner <dlechner@...libre.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: [PATCH 5.10/5.15/6.1 1/1] staging: iio: resolver: ad2s1210: remove call to spi_setup()

From: David Lechner <dlechner@...libre.com>

commit 9829ebacea804ad4b5d1a74a8d94a1f843505546 upstream.

This removes the call to spi_setup() in the ad2s1210 driver.
Setting MODE_3 was incorrect. It should be MODE_1 but we can let the
device tree select this and avoid the need to call spi_setup().

Signed-off-by: David Lechner <dlechner@...libre.com>
Link: https://lore.kernel.org/r/20230929-ad2s1210-mainline-v3-3-fa4364281745@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>
---
 drivers/staging/iio/resolver/ad2s1210.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
index 636c45b12843..42aab1ac3aac 100644
--- a/drivers/staging/iio/resolver/ad2s1210.c
+++ b/drivers/staging/iio/resolver/ad2s1210.c
@@ -681,8 +681,6 @@ static int ad2s1210_probe(struct spi_device *spi)
 		return ret;
 
 	st->fclkin = spi->max_speed_hz;
-	spi->mode = SPI_MODE_3;
-	spi_setup(spi);
 	ad2s1210_initial(st);
 
 	return 0;
-- 
2.30.2