linux-kernel - Re: [PATCH v2] efi: libstub: add support for the apple_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoJDuunseVIDua-m@wunner.de>
Date: Mon, 1 Jul 2024 07:50:50 +0200
From: Lukas Wunner <lukas@...ner.de>
To: Ard Biesheuvel <ardb@...nel.org>
Cc: Aditya Garg <gargaditya08@...e.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
	Kerem Karabay <kekrby@...il.com>,
	Orlando Chamberlain <orlandoch.dev@...il.com>
Subject: Re: [PATCH v2] efi: libstub: add support for the apple_set_os
 protocol

On Mon, Jul 01, 2024 at 07:38:38AM +0200, Ard Biesheuvel wrote:
> Any thoughts on whether this should depend on CONFIG_APPLE_GMUX or not?

I tend towards *not* making it depend on CONFIG_APPLE_GMUX:

* The gpu-switch utility Orlando linked to doesn't use the apple-gmux
  driver.  (It changes EFI variables that influence to which GPU the
  EFI driver will switch on next reboot.)

* apple_set_os() has side effects beyond exposing the iGPU (such as
  switching the keyboard+trackpad access method to SPI instead of USB).
  If there are issues, they will be harder to debug if their occurrence
  depends on a Kconfig option.