| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Jul 2024 14:26:44 +0800
From: zhaoxiong lv <lvzhaoxiong@...qin.corp-partner.google.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: dmitry.torokhov@...il.com, robh@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, jikos@...nel.org,
benjamin.tissoires@...hat.co, dianders@...gle.com, hsinyi@...gle.com,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] drm/panel: starry-er88577: add new panel driver
On Fri, Jun 21, 2024 at 9:43 AM zhaoxiong lv
<lvzhaoxiong@...qin.corp-partner.google.com> wrote:
>
> On Fri, Jun 21, 2024 at 3:56 AM Dmitry Baryshkov
> <dmitry.baryshkov@...aro.org> wrote:
> >
> > On Thu, Jun 20, 2024 at 07:52:45PM GMT, Zhaoxiong Lv wrote:
> > > The bias IC of this starry-er88577 panel is placed
> > > on the panel side, so when the panel is powered on,
> > > there is no need to control AVDD and AVEE in the driver,
> > > only 3.3v and reset are needed.
> > >
> > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@...qin.corp-partner.google.com>
> > > ---
> > > Chage since V3:
> > > - 1. Adjust the ".clock" assignment format.
> > >
> > > v3: https://lore.kernel.org/all/20240614145609.25432-3-lvzhaoxiong@huaqin.corp-partner.google.com/
> > >
> > > Chage since V3:
> > > - Separate Starry-er88577 from the panel-kingdisplay-kd101ne3 driver.
> > > - Use mipi_dsi_dcs_set_display_on_multi().
> > > - Use mipi_dsi_dcs_exit_sleep_mode_multi() and mipi_dsi_msleep().
> > >
> > > v2: https://lore.kernel.org/all/20240601084528.22502-5-lvzhaoxiong@huaqin.corp-partner.google.com/
> > >
> > > Chage since V2:
> > > - Add compatible for Starry er88577 in panel-kingdisplay-kd101ne3 drivers.
> > >
> > > ---
> > > drivers/gpu/drm/panel/Kconfig | 9 +
> > > drivers/gpu/drm/panel/Makefile | 1 +
> > > drivers/gpu/drm/panel/panel-starry-er88577.c | 343 +++++++++++++++++++
> > > 3 files changed, 353 insertions(+)
> > > create mode 100644 drivers/gpu/drm/panel/panel-starry-er88577.c
> > >
> > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> > > index e54f6f5604ed..a52aa2552ab8 100644
> > > --- a/drivers/gpu/drm/panel/Kconfig
> > > +++ b/drivers/gpu/drm/panel/Kconfig
> > > @@ -781,6 +781,15 @@ config DRM_PANEL_SITRONIX_ST7789V
> > > Say Y here if you want to enable support for the Sitronix
> > > ST7789V controller for 240x320 LCD panels
> > >
> > > +config DRM_PANEL_STARRY_ER88577
> > > + tristate "Starry er88577 panel"
> > > + depends on OF
> > > + depends on DRM_MIPI_DSI
> > > + depends on BACKLIGHT_CLASS_DEVICE
> > > + help
> > > + Say Y if you want to enable support for panels based on the
> > > + Starry er88577 controller.
> > > +
> > > config DRM_PANEL_SONY_ACX565AKM
> > > tristate "Sony ACX565AKM panel"
> > > depends on GPIOLIB && OF && SPI
> > > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
> > > index f0203f6e02f4..ecd843a6dc6e 100644
> > > --- a/drivers/gpu/drm/panel/Makefile
> > > +++ b/drivers/gpu/drm/panel/Makefile
> > > @@ -81,6 +81,7 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS060T1SX01) += panel-sharp-ls060t1sx01.o
> > > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o
> > > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o
> > > obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o
> > > +obj-$(CONFIG_DRM_PANEL_STARRY_ER88577) += panel-starry-er88577.o
> > > obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) += panel-synaptics-r63353.o
> > > obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o
> > > obj-$(CONFIG_DRM_PANEL_SONY_TD4353_JDI) += panel-sony-td4353-jdi.o
> > > diff --git a/drivers/gpu/drm/panel/panel-starry-er88577.c b/drivers/gpu/drm/panel/panel-starry-er88577.c
> > > new file mode 100644
> > > index 000000000000..e6088262ee69
> > > --- /dev/null
> > > +++ b/drivers/gpu/drm/panel/panel-starry-er88577.c
> > > @@ -0,0 +1,343 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/* Panels based on the ER88577 display controller.
> > > + * Author: Zhaoxiong Lv <lvzhaoxiong@...qin.corp-partner.google.com>
> > > + */
> > > +
> > > +#include <linux/delay.h>
> > > +#include <linux/gpio/consumer.h>
> > > +#include <linux/module.h>
> > > +#include <linux/of.h>
> > > +#include <linux/regulator/consumer.h>
> > > +
> > > +#include <drm/drm_connector.h>
> > > +#include <drm/drm_crtc.h>
> > > +#include <drm/drm_mipi_dsi.h>
> > > +#include <drm/drm_panel.h>
> > > +
> > > +#include <video/mipi_display.h>
> > > +#include <drm/drm_probe_helper.h>
> > > +
> > > +struct starry_panel;
> > > +
> > > +struct panel_desc {
> > > + const struct drm_display_mode *modes;
> > > + unsigned int bpc;
> > > + unsigned long mode_flags;
> > > + enum mipi_dsi_pixel_format format;
> > > + const struct panel_init_cmd *init_cmds;
> > > + int (*init)(struct starry_panel *starry);
> > > + unsigned int lanes;
> > > + bool discharge_on_disable;
> > > + bool lp11_before_reset;
> > > + unsigned int power_off_delay_ms;
> > > +};
> > > +
> > > +struct starry_panel {
> > > + struct drm_panel base;
> > > + struct mipi_dsi_device *dsi;
> > > +
> > > + const struct panel_desc *desc;
> > > +
> > > + enum drm_panel_orientation orientation;
> > > + struct regulator *vccio;
> > > + struct gpio_desc *reset;
> > > +};
> > > +
> > > +static int starry_er88577_init(struct starry_panel *starry)
> > > +{
> > > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = starry->dsi };
> > > +
> > > + /* T5:HWreset to init_code >= 120ms */
> > > + mipi_dsi_msleep(dsi_ctx, 120);
> > > +
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe0, 0xab, 0xba);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe1, 0xba, 0xab);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb1, 0x10, 0x01, 0x47, 0xff);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb2, 0x0c, 0x14, 0x04, 0x50, 0x50, 0x14);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb3, 0x56, 0x53, 0x00);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb4, 0x33, 0x30, 0x04);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb6, 0xb0, 0x00, 0x00, 0x10, 0x00, 0x10, 0x00);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb8, 0x05, 0x12, 0x29, 0x49, 0x40);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb9, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31,
> > > + 0x1a, 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26,
> > > + 0x0e, 0x06, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31, 0x1a,
> > > + 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, 0x0e,
> > > + 0x06);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc0, 0xcc, 0x76, 0x12, 0x34, 0x44, 0x44, 0x44,
> > > + 0x44, 0x98, 0x04, 0x98, 0x04, 0x0f, 0x00, 0x00, 0xc1);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc1, 0x54, 0x94, 0x02, 0x85, 0x9f, 0x00, 0x6f,
> > > + 0x00, 0x54, 0x00);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc2, 0x17, 0x09, 0x08, 0x89, 0x08, 0x11, 0x22,
> > > + 0x20, 0x44, 0xff, 0x18, 0x00);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc3, 0x87, 0x47, 0x05, 0x05, 0x1c, 0x1c, 0x1d,
> > > + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0f, 0x0f, 0x0d, 0x0d,
> > > + 0x13, 0x13, 0x11, 0x11, 0x24);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc4, 0x06, 0x06, 0x04, 0x04, 0x1c, 0x1c, 0x1d,
> > > + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0e, 0x0e, 0x0c, 0x0c,
> > > + 0x12, 0x12, 0x10, 0x10, 0x24);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc8, 0x21, 0x00, 0x31, 0x42, 0x34, 0x16);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xca, 0xcb, 0x43);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xcd, 0x0e, 0x4b, 0x4b, 0x20, 0x19, 0x6b, 0x06,
> > > + 0xb3);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd2, 0xe3, 0x2b, 0x38, 0x08);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd4, 0x00, 0x01, 0x00, 0x0e, 0x04, 0x44, 0x08,
> > > + 0x10, 0x00, 0x00, 0x00);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe6, 0x80, 0x09, 0xff, 0xff, 0xff, 0xff, 0xff,
> > > + 0xff);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x12, 0x03, 0x20, 0x00, 0xff);
> > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf3, 0x00);
> >
> > NAK.
> >
> > This sequence looks _exactly_ like the sequence in
> > panel-boe-th101mb31ig002-28a.c.
> >
> Hi Dmity
>
> We checked the panel-boe-th101mb31ig002-28a.c driver. The init_code is
> indeed very similar, but the ICs seem to be different from the names,
> and our panels and timings are also different. Do you want us to add
> compatibility with Starry in this driver
> panel-boe-th101mb31ig002-28a.c?
>
> thanks
>
hi dmitry.baryshkov
We tried to make modifications based on the
panel-boe-th101mb31ig002-28a.c driver, but we encountered some
problems.
For example, the panel-boe-th101mb31ig002-28a.c driver will get
"enable/reset" gpio in the probe() function, but our hardware design
only has "enable". This will cause an error to be returned in the
devm_gpiod_get function when we use this driver and the probe()
function will be interrupted.
How should we modify this? Can we re-judge the return value of the
devm_gpiod_get function?
thanks
> > > +
> > > + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
> > > +
> > > + mipi_dsi_msleep(dsi_ctx, 120);
> > > +
> > > + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
> > > + mipi_dsi_msleep(dsi_ctx, 20);
> > > +
> > > + return dsi_ctx.accum_err;
> >
> > --
> > With best wishes
> > Dmitry
Powered by blists - more mailing lists