linux-kernel - Re: [PATCH v2 2/2] cpufreq: acpi: Mark boost policy as enabled when setting boost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240701070737.65escrs7c4gidxc5@vireshk-i7>
Date: Mon, 1 Jul 2024 12:37:37 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Mario Limonciello <mario.limonciello@....com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Gautham R . Shenoy" <gautham.shenoy@....com>,
	Sibi Sankar <quic_sibis@...cinc.com>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Dhruva Gole <d-gole@...com>, Yipeng Zou <zouyipeng@...wei.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH v2 2/2] cpufreq: acpi: Mark boost policy as enabled when
 setting boost

On 26-06-24, 15:47, Mario Limonciello wrote:
> When boost is set for CPUs using acpi-cpufreq the policy is not
> updated which can cause boost to be incorrectly not reported.
> 
> Suggested-by: Viresh Kumar <viresh.kumar@...aro.org>
> Suggested-by: Gautham R. Shenoy <gautham.shenoy@....com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
> Cc: Sibi Sankar <quic_sibis@...cinc.com>
> Cc: Dietmar Eggemann <dietmar.eggemann@....com>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: Dhruva Gole <d-gole@...com>
> Cc: Yipeng Zou <zouyipeng@...wei.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

The below version log needs to go ...

> v1->v2:
>  * Move to init as suggested by Viresh
> ---

... here.

>  drivers/cpufreq/acpi-cpufreq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 2fc82831bddd..fa2664f9f259 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -888,8 +888,10 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
>  	if (perf->states[0].core_frequency * 1000 != freq_table[0].frequency)
>  		pr_warn(FW_WARN "P-state 0 is not max freq\n");
>  
> -	if (acpi_cpufreq_driver.set_boost)
> +	if (acpi_cpufreq_driver.set_boost) {
>  		set_boost(policy, acpi_cpufreq_driver.boost_enabled);
> +		policy->boost_enabled = acpi_cpufreq_driver.boost_enabled;
> +	}
>  
>  	return result;

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh