linux-kernel - Re: [PATCH 10/10] ASoC: fsl: fsl_qmc_audio: Add support for non-interleaved mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240701094719.14f2eda3@bootlin.com>
Date: Mon, 1 Jul 2024 09:47:19 +0200
From: Herve Codina <herve.codina@...tlin.com>
To: Herve Codina <herve.codina@...tlin.com>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Qiang Zhao <qiang.zhao@....com>, Shengjiu Wang
 <shengjiu.wang@...il.com>, Xiubo Li <Xiubo.Lee@...il.com>, Fabio Estevam
 <festevam@...il.com>, Nicolin Chen <nicoleotsuka@...il.com>, Jaroslav
 Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Christophe Leroy
 <christophe.leroy@...roup.eu>
Cc: alsa-devel@...a-project.org, linuxppc-dev@...ts.ozlabs.org,
 linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 10/10] ASoC: fsl: fsl_qmc_audio: Add support for
 non-interleaved mode.

Hi,

On Thu, 20 Jun 2024 10:42:57 +0200
Herve Codina <herve.codina@...tlin.com> wrote:

...
> +static bool qmc_audio_access_is_interleaved(snd_pcm_access_t access)
> +{
> +	switch (access) {
> +	case SNDRV_PCM_ACCESS_MMAP_INTERLEAVED:
> +	case SNDRV_PCM_ACCESS_RW_INTERLEAVED:
> +		return true;
> +	default:
> +		return false;
> +	}
> +};
> +

The ';' at the end of the function should not be here and will be removed
in the next iteration.
Also, this function will be changed to
--- 8< ---
static bool qmc_audio_access_is_interleaved(snd_pcm_access_t access)
{
	switch (access) {
	case SNDRV_PCM_ACCESS_MMAP_INTERLEAVED:
	case SNDRV_PCM_ACCESS_RW_INTERLEAVED:
		return true;
	default:
		break;
	}
	return false;
}
--- 8< ---

Hervé