linux-kernel - Re: [PATCH v3 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc7e3c93-1a79-6911-04c2-19ddc7e298cb@quicinc.com>
Date: Mon, 1 Jul 2024 14:10:20 +0530
From: Naina Mehta <quic_nainmeht@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, <andersson@...nel.org>,
        <mathieu.poirier@...aro.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <manivannan.sadhasivam@...aro.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/5] arm64: dts: qcom: sdx75: update reserved memory
 regions for mpss



On 6/26/2024 9:12 PM, Konrad Dybcio wrote:
> On 24.06.2024 1:21 PM, Naina Mehta wrote:
>>
>>
>> On 6/18/2024 7:08 PM, Konrad Dybcio wrote:
>>>
>>>
>>> On 6/18/24 15:13, Naina Mehta wrote:
>>>> Rename qdss@...00000 memory region as qlink_logging memory region
>>>> and add qdss_mem memory region at address of 0x88500000.
>>>> Split mpss_dsmharq_mem region into 2 separate regions and
>>>> reduce the size of mpssadsp_mem region.
>>>>
>>>> Signed-off-by: Naina Mehta <quic_nainmeht@...cinc.com>
>>>> ---
>>>
>>> Alright, we're getting somewhere. The commit message should however motivate
>>> why such changes are necessary. For all we know, the splitting in two is
>>> currently done for no reason, as qdss_mem and qlink_logging_mem are contiguous
>>> - does the firmware have some expectations about them being separate?
>>>
>>
>> Since different DSM region size is required for different modem firmware, mpss_dsmharq_mem region being split into 2 separate regions.
>> This would provide the flexibility to remove the region which is
>> not required for a particular platform.
>> qlink_logging is being added at the memory region at the address of
>> 0x88800000 as the region is being used by modem firmware.
> 
> Ok, now put that in the commit message :)
> 
> And I suppose:
> 
> "This would provide the flexibility to remove the region which is not
> required for a particular platform." - but you still pass both to the
> remoteproc in patch 4. Are these regions mutually exclusive?
> 

Yes, for IDP platform, we are using both the DSM regions.
Based on the modem firmware either both the regions have to be used or 
only mpss_dsm_mem has to be used.

Regards,
Naina

> Konrad
>