[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3fe026a2-a8d6-4688-863f-1237e71945ea@kernel.org>
Date: Mon, 1 Jul 2024 10:41:30 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jacobe Zang <jacobe.zang@...ion.com>,
"arend.vanspriel@...adcom.com" <arend.vanspriel@...adcom.com>
Cc: "kvalo@...nel.org" <kvalo@...nel.org>,
"duoming@....edu.cn" <duoming@....edu.cn>,
"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
"minipli@...ecurity.net" <minipli@...ecurity.net>,
"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
"brcm80211@...ts.linux.dev" <brcm80211@...ts.linux.dev>,
"brcm80211-dev-list.pdl@...adcom.com" <brcm80211-dev-list.pdl@...adcom.com>,
"megi@....cz" <megi@....cz>, "robh@...nel.org" <robh@...nel.org>,
"efectn@...tonmail.com" <efectn@...tonmail.com>,
"krzk+dt@...nel.org" <krzk+dt@...nel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
"heiko@...ech.de" <heiko@...ech.de>, Nick Xie <nick@...das.com>,
"jagan@...eble.ai" <jagan@...eble.ai>,
"dsimic@...jaro.org" <dsimic@...jaro.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-rockchip@...ts.infradead.org" <linux-rockchip@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/5] arm64: dts: rockchip: Add AP6275P wireless support
to Khadas Edge 2
On 25/06/2024 10:04, Jacobe Zang wrote:
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
>>> index 3b6286461a746..f674deb6f7da8 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
>>> @@ -356,6 +356,22 @@ &pcie2x1l2 {
>>> reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>;
>>> vpcie3v3-supply = <&vcc3v3_pcie_wl>;
>>> status = "okay";
>>> +
>>> + pcie@0,0 {
>>> + reg = <0x400000 0 0 0 0>;
>>> + #address-cells = <3>;
>>> + #size-cells = <2>;
>>> + ranges;
>>> + device_type = "pci";
>>> + bus-range = <0x40 0x4f>;
>>
>> Isn't bus-range a property of PCI host bridge, so the parent? This is a
>> PCI device, right?
>>
>>> +
>>> + wifi: wifi@0,0 {
>>
>> Binding does not say anything about this. Rockchip PCI controller is the
>> PCI host bridge, isn't it? Then the pci@0,0 is the child, so what is this?
>
> The host bridge is the parent of pcie@0,0. And pcie@0,0 is Bridge1, so the
Do you want to say Rockchip PCI is PCI-PCI bridge? Bindings do not allow it.
> wifi@0,0 as a device under the Bridge1.
>
>>
>>> + reg = <0x410000 0 0 0 0>;
>>> + clocks = <&hym8563>;
>>> + clock-names = "32k";
>>
>> 1. Bindings are before the users.
>> 2. Where is the compatible? Are you sure this validates?
>
> Before, the compatible is "pci14e4,449d", but when I checkpatch the warning
> said that "pci14e4" was not documented, so I remove the compatible which
> doesn't affect the Wi-Fi function. I have tried to add "pci14e4" to
> vendor-prefixes.yaml but was refused. So whether should I add the compatible
> with warning?
I talk about dtbs_check, not checkpatch. That checkpatch warning does
not matter, obviously.
Best regards,
Krzysztof
Powered by blists - more mailing lists