[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <831bad74-5519-48a1-b13c-a358e634598c@kernel.org>
Date: Mon, 1 Jul 2024 10:58:18 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jacobe Zang <jacobe.zang@...ion.com>, robh@...nel.org,
krzk+dt@...nel.org, heiko@...ech.de, kvalo@...nel.org, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, conor+dt@...nel.org
Cc: efectn@...tonmail.com, dsimic@...jaro.org, jagan@...eble.ai,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
arend@...adcom.com, linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
megi@....cz, duoming@....edu.cn, bhelgaas@...gle.com,
minipli@...ecurity.net, brcm80211@...ts.linux.dev,
brcm80211-dev-list.pdl@...adcom.com, nick@...das.com
Subject: Re: [PATCH v3 2/5] dt-bindings: net: wireless: brcm4329-fmac: add
clock description for AP6275P Wi-Fi device
On 30/06/2024 09:36, Jacobe Zang wrote:
> Add clocks and clock-names for brcm4329-fmac.
>
> Signed-off-by: Jacobe Zang <jacobe.zang@...ion.com>
> ---
> .../bindings/net/wireless/brcm,bcm4329-fmac.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index 2c2093c77ec9a..f542b60e44dc4 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -122,6 +122,14 @@ properties:
> NVRAM. This would normally be filled in by the bootloader from platform
> configuration data.
>
> + clocks:
> + items:
> + - description: Wi-Fi RTC clock
> +
> + clock-names:
> + items:
> + - const: lpo
This does not match your DTS. DTS is different, e.g. does not have
compatible. There are required properties here, some of which are required.
Best regards,
Krzysztof
Powered by blists - more mailing lists