[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5d0950fd-dcd2-4996-aab0-0030f1911960@kernel.org>
Date: Mon, 1 Jul 2024 11:12:13 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jim Quinlan <james.quinlan@...adcom.com>, linux-pci@...r.kernel.org,
Nicolas Saenz Julienne <nsaenz@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Cyril Brulebois <kibi@...ian.org>, Stanimir Varbanov <svarbanov@...e.de>,
bcm-kernel-feedback-list@...adcom.com, jim2101024@...il.com
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof WilczyĆski <kw@...ux.com>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@...ts.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@...ts.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/8] dt-bindings: PCI: Add Broadcom STB 7712 SOC,
update maintainter
On 28/06/2024 22:54, Jim Quinlan wrote:
> - Update maintainer.
Why?
> - Adds a driver compatible string for the new STB SOC 7712
> - Adds two new resets for the 7712: "bridge", for the
> the bridge between the PCIe core and the memory bus;
> and "swinit", the PCIe core reset.
>
> Signed-off-by: Jim Quinlan <james.quinlan@...adcom.com>
> ---
> .../bindings/pci/brcm,stb-pcie.yaml | 24 ++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 11f8ea33240c..f594fef343a1 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -7,12 +7,13 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> title: Brcmstb PCIe Host Controller
>
> maintainers:
> - - Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
> + - Jim Quinlan <james.quinlan@...adcom.com>
>
> properties:
> compatible:
> items:
> - enum:
> + - brcm,bcm7712-pcie # STB sibling SOC of Raspberry Pi 5
Why did you place it here? Isn't the list ordered?
> - brcm,bcm2711-pcie # The Raspberry Pi 4
> - brcm,bcm4908-pcie
> - brcm,bcm7211-pcie # Broadcom STB version of RPi4
> @@ -146,6 +147,27 @@ allOf:
> required:
> - resets
> - reset-names
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: brcm,bcm7712-pcie
> + then:
> + properties:
> + resets:
Fix the binding first - properties should be defined in top level
"properties:" and then customized. Where are "resets"?
> + items:
> + - description: phandle pointing to the RESCAL reset controller
Drop redundant text. There is no point in saying that phandle is a
phandle. It's obvious. Say something which is not obvious.
Best regards,
Krzysztof
Powered by blists - more mailing lists