| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20240701-mgtime-v2-3-19d412a940d9@kernel.org>
Date: Mon, 01 Jul 2024 06:26:39 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Alexander Viro <viro@...iv.linux.org.uk>,
Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
Steven Rostedt <rostedt@...dmis.org>,
Masami Hiramatsu <mhiramat@...nel.org>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Chandan Babu R <chandan.babu@...cle.com>,
"Darrick J. Wong" <djwong@...nel.org>, Theodore Ts'o <tytso@....edu>,
Andreas Dilger <adilger.kernel@...ger.ca>, Chris Mason <clm@...com>,
Josef Bacik <josef@...icpanda.com>, David Sterba <dsterba@...e.com>,
Hugh Dickins <hughd@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>
Cc: Andi Kleen <ak@...ux.intel.com>, kernel-team@...com,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-trace-kernel@...r.kernel.org, linux-xfs@...r.kernel.org,
linux-ext4@...r.kernel.org, linux-btrfs@...r.kernel.org, linux-mm@...ck.org,
linux-nfs@...r.kernel.org, Jeff Layton <jlayton@...nel.org>
Subject: [PATCH v2 03/11] fs: tracepoints for inode_needs_update_time and
inode_set_ctime_to_ts
Add a new tracepoint for when we're testing whether the timestamps need
updating, and around the update itself.
Signed-off-by: Jeff Layton <jlayton@...nel.org>
---
fs/inode.c | 4 +++
include/trace/events/timestamp.h | 76 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 80 insertions(+)
diff --git a/fs/inode.c b/fs/inode.c
index 7b0a73ed499d..5d2b0dfe48c3 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -22,6 +22,8 @@
#include <linux/iversion.h>
#include <linux/rw_hint.h>
#include <trace/events/writeback.h>
+#define CREATE_TRACE_POINTS
+#include <trace/events/timestamp.h>
#include "internal.h"
/*
@@ -2096,6 +2098,7 @@ static int inode_needs_update_time(struct inode *inode)
if (IS_I_VERSION(inode) && inode_iversion_need_inc(inode))
sync_it |= S_VERSION;
+ trace_inode_needs_update_time(inode, &now, &ts, sync_it);
return sync_it;
}
@@ -2522,6 +2525,7 @@ EXPORT_SYMBOL(inode_get_ctime);
struct timespec64 inode_set_ctime_to_ts(struct inode *inode, struct timespec64 ts)
{
inode->__i_ctime = ktime_set(ts.tv_sec, ts.tv_nsec);
+ trace_inode_set_ctime_to_ts(inode, &ts);
return ts;
}
EXPORT_SYMBOL(inode_set_ctime_to_ts);
diff --git a/include/trace/events/timestamp.h b/include/trace/events/timestamp.h
new file mode 100644
index 000000000000..35ff875d3800
--- /dev/null
+++ b/include/trace/events/timestamp.h
@@ -0,0 +1,76 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#undef TRACE_SYSTEM
+#define TRACE_SYSTEM timestamp
+
+#if !defined(_TRACE_TIMESTAMP_H) || defined(TRACE_HEADER_MULTI_READ)
+#define _TRACE_TIMESTAMP_H
+
+#include <linux/tracepoint.h>
+#include <linux/fs.h>
+
+TRACE_EVENT(inode_needs_update_time,
+ TP_PROTO(struct inode *inode,
+ struct timespec64 *now,
+ struct timespec64 *ctime,
+ int sync_it),
+
+ TP_ARGS(inode, now, ctime, sync_it),
+
+ TP_STRUCT__entry(
+ __field(dev_t, dev)
+ __field(ino_t, ino)
+ __field(time64_t, now_sec)
+ __field(time64_t, ctime_sec)
+ __field(long, now_nsec)
+ __field(long, ctime_nsec)
+ __field(int, sync_it)
+ ),
+
+ TP_fast_assign(
+ __entry->dev = inode->i_sb->s_dev;
+ __entry->ino = inode->i_ino;
+ __entry->sync_it = sync_it;
+ __entry->now_sec = now->tv_sec;
+ __entry->ctime_sec = ctime->tv_sec;
+ __entry->now_nsec = now->tv_nsec;
+ __entry->ctime_nsec = ctime->tv_nsec;
+ __entry->sync_it = sync_it;
+ ),
+
+ TP_printk("ino=%d:%d:%ld sync_it=%d now=%llu.%ld ctime=%llu.%lu",
+ MAJOR(__entry->dev), MINOR(__entry->dev), __entry->ino,
+ __entry->sync_it,
+ __entry->now_sec, __entry->now_nsec,
+ __entry->ctime_sec, __entry->ctime_nsec
+ )
+);
+
+TRACE_EVENT(inode_set_ctime_to_ts,
+ TP_PROTO(struct inode *inode,
+ struct timespec64 *ts),
+
+ TP_ARGS(inode, ts),
+
+ TP_STRUCT__entry(
+ __field(dev_t, dev)
+ __field(ino_t, ino)
+ __field(time64_t, ts_sec)
+ __field(long, ts_nsec)
+ ),
+
+ TP_fast_assign(
+ __entry->dev = inode->i_sb->s_dev;
+ __entry->ino = inode->i_ino;
+ __entry->ts_sec = ts->tv_sec;
+ __entry->ts_nsec = ts->tv_nsec;
+ ),
+
+ TP_printk("ino=%d:%d:%ld ts=%llu.%lu",
+ MAJOR(__entry->dev), MINOR(__entry->dev), __entry->ino,
+ __entry->ts_sec, __entry->ts_nsec
+ )
+);
+#endif /* _TRACE_TIMESTAMP_H */
+
+/* This part must be outside protection */
+#include <trace/define_trace.h>
--
2.45.2
Powered by blists - more mailing lists