linux-kernel - Re: [PATCH v2] arm64: dts: qcom: qrb4210-rb2: Correct PMI632 VBUS ampere

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D2E4R2MLD3ZY.S3QF3GPPFQK0@fairphone.com>
Date: Mon, 01 Jul 2024 12:28:32 +0200
From: "Luca Weiss" <luca.weiss@...rphone.com>
To: "Dang Huynh" <danct12@...eup.net>, "Bjorn Andersson"
 <andersson@...nel.org>, "Konrad Dybcio" <konrad.dybcio@...aro.org>, "Rob
 Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Conor Dooley" <conor+dt@...nel.org>
Cc: "Dmitry Baryshkov" <dmitry.baryshkov@...aro.org>,
 <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: qrb4210-rb2: Correct PMI632 VBUS
 ampere

On Mon Jul 1, 2024 at 12:24 PM CEST, Dang Huynh wrote:
> According to downstream sources, PMI632 maximum VBUS ampere is
> 1A.
>
> Taken from msm-4.19 (631561973a034e46ccacd0e53ef65d13a40d87a4)
> Line 685-687 in drivers/power/supply/qcom/qpnp-smb5.c
>
> Signed-off-by: Dang Huynh <danct12@...eup.net>

Fixes: a06a2f12f9e2 ("arm64: dts: qcom: qrb4210-rb2: enable USB-C port handling")
Reviewed-by: Luca Weiss <luca.weiss@...rphone.com>

> ---
> In previous patch series, there's a suggestion to correct
> PMI632's VBUS ampere.
>
> Unfortunately it didn't make it and probably forgotten.

Could've included a link for easier context:
https://lore.kernel.org/linux-arm-msm/CYMDEAJZ0TJK.K31XZB3E9QOG@fairphone.com/

>
> ----
> Changes in v2:
> - Fixed typo (voltage -> ampere)
> - Link to v1: https://lore.kernel.org/r/20240701-qrd4210rb2-vbus-volt-v1-1-5c06f8358436@riseup.net
> ---
>  arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index 1c7de7f2db79..1888d99d398b 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -305,7 +305,7 @@ pmi632_ss_in: endpoint {
>  
>  &pmi632_vbus {
>  	regulator-min-microamp = <500000>;
> -	regulator-max-microamp = <3000000>;
> +	regulator-max-microamp = <1000000>;
>  	status = "okay";
>  };
>  
>
> ---
> base-commit: 642a16ca7994a50d7de85715996a8ce171a5bdfb
> change-id: 20240701-qrd4210rb2-vbus-volt-822764c7cfca
>
> Best regards,