linux-kernel - Re: [PATCH v2] efi: libstub: add support for the apple_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <423C19DA-AA94-415B-9184-5C8EA01DAC01@live.com>
Date: Mon, 1 Jul 2024 10:40:13 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Ard Biesheuvel <ardb@...nel.org>
CC: Lukas Wunner <lukas@...ner.de>, Hans de Goede <hdegoede@...hat.com>, Linux
 Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>, Kerem Karabay
	<kekrby@...il.com>, Orlando Chamberlain <orlandoch.dev@...il.com>
Subject: Re: [PATCH v2] efi: libstub: add support for the apple_set_os
 protocol



> On 1 Jul 2024, at 1:21 PM, Ard Biesheuvel <ardb@...nel.org> wrote:
> 
> On Mon, 1 Jul 2024 at 09:44, Lukas Wunner <lukas@...ner.de> wrote:
>> 
>> On Mon, Jul 01, 2024 at 09:30:34AM +0200, Ard Biesheuvel wrote:
>>> Assuming that Intel Macs implement the EFI SMBIOS protocol, reusing
>>> the existing pieces should be rather straight-forward. Something like
>>> the below should work in that case (whitespace damage courtesy of
>>> gmail)
>>> 
>>> Note that the smbios.c  libstub source file needs some changes to
>>> build correctly for x86 with CONFIG_EFI_MIXED=y, but I can take care
>>> of that.
>> 
>> Orlando, Aditya, could you test Ard's patch with CONFIG_EFI_MIXED=n?
>> 
> 
> Yes, please test so we can check whether Intel Macs expose this
> protocol in the first place.
> 
> Note that the following hunk is needed too:
> 

The patch works Ard

Tested-by: Aditya Garg <gargaditya08@...e.com>

For reference, here is kernel configuration of the kernel used to test this: https://pastebin.com/GPaxRWC6
> diff --git a/drivers/firmware/efi/libstub/Makefile
> b/drivers/firmware/efi/libstub/Makefile
> index 06f0428a723c..1f32d6cf98d6 100644
> --- a/drivers/firmware/efi/libstub/Makefile
> +++ b/drivers/firmware/efi/libstub/Makefile
> @@ -77,5 +77,5 @@
> lib-$(CONFIG_ARM)              += arm32-stub.o
> lib-$(CONFIG_ARM64)            += kaslr.o arm64.o arm64-stub.o smbios.o
> -lib-$(CONFIG_X86)              += x86-stub.o
> +lib-$(CONFIG_X86)              += x86-stub.o smbios.o
> lib-$(CONFIG_X86_64)           += x86-5lvl.o
> lib-$(CONFIG_RISCV)            += kaslr.o riscv.o riscv-stub.o