linux-kernel - Re: [PATCH] s390/dasd: fix error checks in dasd_copy_pair

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c41c53e4-aa6d-47b7-b928-0c1b9e8dcdc3@linux.ibm.com>
Date: Mon, 1 Jul 2024 12:58:12 +0200
From: Stefan Haberland <sth@...ux.ibm.com>
To: Carlos López <clopez@...e.de>, linux-s390@...r.kernel.org
Cc: Jan Hoeppner <hoeppner@...ux.ibm.com>, Heiko Carstens
 <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, Jens Axboe <axboe@...nel.dk>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] s390/dasd: fix error checks in dasd_copy_pair_store()

Am 27.05.24 um 15:50 schrieb Carlos López:
> dasd_add_busid() can return an error via ERR_PTR() if an allocation
> fails. However, two callsites in dasd_copy_pair_store() do not check
> the result, potentially resulting in a NULL pointer dereference. Fix
> this by checking the result with IS_ERR() and returning the error up
> the stack.
>
> Fixes: a91ff09d39f9b ("s390/dasd: add copy pair setup")
> Signed-off-by: Carlos López <clopez@...e.de>
> ---

Applied, thanks.