linux-kernel - Re: [PATCH v3 3/5] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 1 Jul 2024 15:04:06 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jacobe Zang <jacobe.zang@...ion.com>, "robh@...nel.org"
 <robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "heiko@...ech.de" <heiko@...ech.de>, "kvalo@...nel.org" <kvalo@...nel.org>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>
Cc: "efectn@...tonmail.com" <efectn@...tonmail.com>,
 "dsimic@...jaro.org" <dsimic@...jaro.org>,
 "jagan@...eble.ai" <jagan@...eble.ai>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-rockchip@...ts.infradead.org" <linux-rockchip@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "arend@...adcom.com" <arend@...adcom.com>,
 "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "megi@....cz"
 <megi@....cz>, "duoming@....edu.cn" <duoming@....edu.cn>,
 "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
 "minipli@...ecurity.net" <minipli@...ecurity.net>,
 "brcm80211@...ts.linux.dev" <brcm80211@...ts.linux.dev>,
 "brcm80211-dev-list.pdl@...adcom.com" <brcm80211-dev-list.pdl@...adcom.com>,
 Nick Xie <nick@...das.com>
Subject: Re: [PATCH v3 3/5] arm64: dts: rockchip: Add AP6275P wireless support
 to Khadas Edge 2

On 01/07/2024 13:31, Jacobe Zang wrote:
>>>> +     pcie@0,0 {
>>>> +             reg = <0x400000 0 0 0 0>;
>>>> +             #address-cells = <3>;
>>>> +             #size-cells = <2>;
>>>> +             ranges;
>>>> +             device_type = "pci";
>>>> +             bus-range = <0x40 0x4f>;
>>>> +
>>>> +             wifi: wifi@0,0 {
>>> Where is the compatible (again!)? Test your code - you will see your
>>> binding is a no-op.
>>
>> I tried to build kernel with CHECK_DTBS=1. And didn't get any message
>> like 'compatible' is a required property in wifi node. But when I check
>> the bindings that do required the compatible... So I will add it next time.
> 
>> Yep, use different clock name and then test. You should see errors,
>> right? But there are not, because schema is not applied to this node at all.
>>
>> Look how Apple is doing this.
>>
>> I have doubts that your code works at all in the first place. If there
>> is no compatible, how your platform device gets of_node?
> 
> In file brcm_hw_ids.h and pcie.c has added Device ID and Vendor ID
> for bus to enumerate the device when board bootup, so I didn't add
> specific compatible in DTS. And by doing so, it can probe successfully.

I did not ask about probe()... that's quite obvious. How the device's
of_node is assigned?

Best regards,
Krzysztof