linux-kernel - Re: [PATCH v3 08/10] perf/x86/rapl: Modify the generic variable names to *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240701130845.GI20127@noisy.programming.kicks-ass.net>
Date: Mon, 1 Jul 2024 15:08:45 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Dhananjay Ugwekar <Dhananjay.Ugwekar@....com>
Cc: mingo@...hat.com, acme@...nel.org, namhyung@...nel.org,
	mark.rutland@....com, alexander.shishkin@...ux.intel.com,
	jolsa@...nel.org, irogers@...gle.com, adrian.hunter@...el.com,
	kan.liang@...ux.intel.com, tglx@...utronix.de, bp@...en8.de,
	dave.hansen@...ux.intel.com, x86@...nel.org, kees@...nel.org,
	gustavoars@...nel.org, rui.zhang@...el.com,
	oleksandr@...alenko.name, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
	ananth.narayan@....com, gautham.shenoy@....com,
	kprateek.nayak@....com, ravi.bangoria@....com, sandipan.das@....com,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 08/10] perf/x86/rapl: Modify the generic variable
 names to *_pkg*

On Mon, Jun 24, 2024 at 05:59:05AM +0000, Dhananjay Ugwekar wrote:
> Prep for addition of power_per_core PMU to handle core scope energy
> consumption for AMD CPUs.
> 
> Replace the generic names with *_pkg*, to differentiate between the
> scopes of the two different PMUs and their variables.

But then remember patch 2 and recall that intel seems to have everything
at die level, not pkg.

Does this proposed naming make sense? How?