linux-kernel - RE: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Add name_prefix as the prefix name of DSP firmwares and calibrated data files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <664b818a177f4403bd60c3d4cd0bf4d1@ti.com>
Date: Mon, 1 Jul 2024 14:00:13 +0000
From: "Ding, Shenghao" <shenghao-ding@...com>
To: Mark Brown <broonie@...nel.org>
CC: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz"
	<perex@...ex.cz>,
        "pierre-louis.bossart@...ux.intel.com"
	<pierre-louis.bossart@...ux.intel.com>,
        "13916275206@....com"
	<13916275206@....com>,
        "zhourui@...qin.com" <zhourui@...qin.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "Salazar, Ivan"
	<i-salazar@...com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "Chadha, Jasjot Singh" <j-chadha@...com>,
        "liam.r.girdwood@...el.com" <liam.r.girdwood@...el.com>,
        "Yue, Jaden"
	<jaden-yue@...com>,
        "yung-chuan.liao@...ux.intel.com"
	<yung-chuan.liao@...ux.intel.com>,
        "Rao, Dipa" <dipa@...com>, "yuhsuan@...gle.com" <yuhsuan@...gle.com>,
        "Lo, Henry" <henry.lo@...com>, "tiwai@...e.de" <tiwai@...e.de>,
        "Xu, Baojun" <baojun.xu@...com>, "soyer@....hu" <soyer@....hu>,
        "Baojun.Xu@....com" <Baojun.Xu@....com>,
        "judyhsiao@...gle.com" <judyhsiao@...gle.com>,
        "Navada Kanyana, Mukund"
	<navada@...com>,
        "cujomalainey@...gle.com" <cujomalainey@...gle.com>,
        "Kutty,
 Aanya" <aanya@...com>,
        "Mahmud, Nayeem" <nayeem.mahmud@...com>,
        "savyasanchi.shukla@...radyne.com" <savyasanchi.shukla@...radyne.com>,
        "flaviopr@...rosoft.com" <flaviopr@...rosoft.com>,
        "Ji, Jesse"
	<jesse-ji@...com>,
        "darren.ye@...iatek.com" <darren.ye@...iatek.com>
Subject: RE: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Add name_prefix as the
 prefix name of DSP firmwares and calibrated data files

Hi Brown
Thanks for your comment.

> -----Original Message-----
> From: Mark Brown <broonie@...nel.org>
> Sent: Monday, July 1, 2024 8:23 PM
> To: Ding, Shenghao <shenghao-ding@...com>
> Cc: andriy.shevchenko@...ux.intel.com; lgirdwood@...il.com;
> perex@...ex.cz; pierre-louis.bossart@...ux.intel.com;
> 13916275206@....com; zhourui@...qin.com; alsa-devel@...a-project.org;
> Salazar, Ivan <i-salazar@...com>; linux-kernel@...r.kernel.org; Chadha,
> Jasjot Singh <j-chadha@...com>; liam.r.girdwood@...el.com; Yue, Jaden
> <jaden-yue@...com>; yung-chuan.liao@...ux.intel.com; Rao, Dipa
> <dipa@...com>; yuhsuan@...gle.com; Lo, Henry <henry.lo@...com>;
> tiwai@...e.de; Xu, Baojun <baojun.xu@...com>; soyer@....hu;
> Baojun.Xu@....com; judyhsiao@...gle.com; Navada Kanyana, Mukund
> <navada@...com>; cujomalainey@...gle.com; Kutty, Aanya
> <aanya@...com>; Mahmud, Nayeem <nayeem.mahmud@...com>;
> savyasanchi.shukla@...radyne.com; flaviopr@...rosoft.com; Ji, Jesse
> <jesse-ji@...com>; darren.ye@...iatek.com
> Subject: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Add name_prefix as the
> prefix name of DSP firmwares and calibrated data files
> 
> On Sat, Jun 29, 2024 at 06:11:10PM +0800, Shenghao Ding wrote:
> 
> >  	tas_priv->fw_state = TASDEVICE_RCA_FW_OK;
> > -	scnprintf(tas_priv->coef_binaryname, 64, "%s_coef.bin",
> > -		tas_priv->dev_name);
> > +	if (tas_priv->name_prefix)
> > +		scnprintf(tas_priv->rca_binaryname, 64, "%s-%s_coef.bin",
> > +			tas_priv->name_prefix, tas_priv->dev_name);
> > +	else
> > +		scnprintf(tas_priv->coef_binaryname, 64, "%s_coef.bin",
> > +			tas_priv->dev_name);
> 
> I'll apply this but I do wonder if it's worth falling back to trying to load the
> unprefixed name if we fail to load the prefixed one.
If fail to load dsp firmware, the driver won't load unprefixed name firmware, 
but switch tas2563/tas2781 to bypass-dsp mode automatically.
In this mode, smartamp become simple amp.
These day, I met a case from one of my customers, they put 2 pieces of tas2563, 
and 2 pieces of tas2781 in the same i2c bus. In order to identify tas2563 and 
tas2781, I think name_prefix is a good solution for this case.
Looking forward to your comment. Thanks.