linux-kernel - Re: [PATCH v1 3/3] ASoC: codecs: wcd937x: Remove separate handling for vdd-buck supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a8a670f9-f03f-eff8-5cb2-b40b06267bc6@quicinc.com>
Date: Mon, 1 Jul 2024 19:34:51 +0530
From: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
To: Mark Brown <broonie@...nel.org>
CC: Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Prasad Kumpatla <quic_pkumpatl@...cinc.com>,
        <linux-sound@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_rohkumar@...cinc.com>
Subject: Re: [PATCH v1 3/3] ASoC: codecs: wcd937x: Remove separate handling
 for vdd-buck supply

On 6/28/2024 6:12 PM, Mark Brown wrote:
> On Fri, Jun 28, 2024 at 03:41:43PM +0530, Mohammad Rafi Shaik wrote:
> 
Thanks for the review.
>> Replace free_irq() with devm_free_irq() because irq have been requested
>> wth devm_request_threaded_irq().
> 
> This seems like an unrelated change, and TBH if explict frees are
> required I'd question if devm_ should be being used in the first place.

okay, will remove this specific change from patch change.

Based on review comments added devm_free_irq().

https://lore.kernel.org/all/f741630e-f9e8-45e1-b3e2-4866f0baeac2@sirena.org.uk/

Thanks and Regards,
Rafi.