linux-kernel - Re: [PATCH net-next v22 01/13] rtase: Add support for a pci table in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 2 Jul 2024 17:48:29 +0100
From: Simon Horman <horms@...nel.org>
To: Justin Lai <justinlai0215@...ltek.com>
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, andrew@...n.ch, jiri@...nulli.us,
	rkannoth@...vell.com, jdamato@...tly.com, pkshih@...ltek.com,
	larry.chiu@...ltek.com
Subject: Re: [PATCH net-next v22 01/13] rtase: Add support for a pci table in
 this module

On Mon, Jul 01, 2024 at 07:53:51PM +0800, Justin Lai wrote:
> Add support for a pci table in this module, and implement pci_driver
> function to initialize this driver, remove this driver, or shutdown
> this driver.
> 
> Signed-off-by: Justin Lai <justinlai0215@...ltek.com>
> ---
>  drivers/net/ethernet/realtek/rtase/rtase.h    | 338 ++++++++++
>  .../net/ethernet/realtek/rtase/rtase_main.c   | 638 ++++++++++++++++++
>  2 files changed, 976 insertions(+)
>  create mode 100755 drivers/net/ethernet/realtek/rtase/rtase.h
>  create mode 100755 drivers/net/ethernet/realtek/rtase/rtase_main.c
> 
> diff --git a/drivers/net/ethernet/realtek/rtase/rtase.h b/drivers/net/ethernet/realtek/rtase/rtase.h
> new file mode 100755

nit: Source files should not have the execute bit(s) set.

     Flagged by Checkpatch.

Otherwise, this patch looks good to me.