linux-kernel - Re: [PATCH 1/1] dt-bindings: PCI: host-generic-pci: Increase maxItems to 8 of ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoQyO2Ycl7pVDAYV@lizhi-Precision-Tower-5810>
Date: Tue, 2 Jul 2024 13:00:43 -0400
From: Frank Li <Frank.li@....com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Will Deacon <will@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kw@...ux.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"open list:PCI DRIVER FOR GENERIC OF HOSTS" <linux-pci@...r.kernel.org>,
	"moderated list:PCI DRIVER FOR GENERIC OF HOSTS" <linux-arm-kernel@...ts.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: PCI: host-generic-pci: Increase
 maxItems to 8 of ranges

On Tue, Jul 02, 2024 at 11:43:50AM -0500, Bjorn Helgaas wrote:
> On Tue, Jul 02, 2024 at 11:37:02AM -0400, Frank Li wrote:
> > IEEE Std 1275-1994 is Inactive-Withdrawn Standard according to
> > https://standards.ieee.org/ieee/1275/1932/.
> 
> I'm not quite sure what the connection is?  Is the sentence below a
> quote from the spec above?  Perhaps include the section number it came
> from?

I quote from original yaml file. This spec is not free. I can't access
this spec so far. But I think limited to 3 is not reasonable.

Frank Li

> 
> > "require at least one non-prefetchable memory and One or both of
> > prefetchable Memory and IO Space may also be provided". But it does not
> > limit maximum ranges number is 3.
> 
> "But IEEE Std 1275-1994 does not limit maximum ranges to 3"?
> 
> > Inscrease maximum to 8 because freescale ls1028 and iMX95 use more than
> > 3 ranges.
> 
> s/Inscrease/Increase/
> 
> > Fix below CHECK_DTBS warning.
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dtb: pcie@...000000: ranges: [[2181038080, 1, 4160749568, 1, 4160749568, 0, 1441792], [3254779904, 1, 4162191360, 1, 4162191360, 0, 458752], [2181038080, 1, 4162650112, 1, 4162650112, 0, 131072], [3254779904, 1, 4162781184, 1, 4162781184, 0, 131072], [2181038080, 1, 4162912256, 1, 4162912256, 0, 131072], [3254779904, 1, 4163043328, 1, 4163043328, 0, 131072], [2181038080, 1, 4227858432, 1, 4227858432, 0, 4194304]] is too long
> > 
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> >  Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml
> > index 3484e0b4b412e..506eed7f6c63d 100644
> > --- a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml
> > +++ b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml
> > @@ -103,7 +103,7 @@ properties:
> >        definition of non-prefetchable memory. One or both of prefetchable Memory
> >        and IO Space may also be provided.
> >      minItems: 1
> > -    maxItems: 3
> > +    maxItems: 8
> >  
> >    dma-coherent: true
> >    iommu-map: true
> > -- 
> > 2.34.1
> >