linux-kernel - Re: [PATCH v23 14/19] x86/resctrl: Handle removing directories in Sub-NUMA Cluster (SNC) mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240702172809.GGZoQ4qW6OOkL0bQQ7@fat_crate.local>
Date: Tue, 2 Jul 2024 19:28:09 +0200
From: Borislav Petkov <bp@...en8.de>
To: Tony Luck <tony.luck@...el.com>
Cc: Fenghua Yu <fenghua.yu@...el.com>,
	Reinette Chatre <reinette.chatre@...el.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>,
	Peter Newman <peternewman@...gle.com>,
	James Morse <james.morse@....com>, Babu Moger <babu.moger@....com>,
	Drew Fustini <dfustini@...libre.com>,
	Dave Martin <Dave.Martin@....com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH v23 14/19] x86/resctrl: Handle removing directories in
 Sub-NUMA Cluster (SNC) mode

On Tue, Jul 02, 2024 at 10:16:39AM -0700, Tony Luck wrote:
> A helper will avoid this duplication. Draft below. Is this
> what you want?

Yap, looks good.

> Is the function name OK. I wasn't sure if the
> "mon" looked better at the beginning. Or as rmdir_one_mon_subdir()

It's a static function so the namespace doesn't matter that much, I'd say.

> I've also fixed up part 17 to use msr_clear_bit()

Good.

> Are you still digging through the patches?

Yap, and you can send me only those two which you've modified and I'll
integrate them with the rest and queue them.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette