linux-kernel - Re: [PATCH] PCI/pwrctl: Decrease message about child OF nodes to debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MfBJi2BGZxfLHgbu2AgRyZ9Z_smWMCy_hD6HuW3HxrNsw@mail.gmail.com>
Date: Tue, 2 Jul 2024 20:00:49 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: superm1@...nel.org
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, linux-pci@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Mario Limonciello <mario.limonciello@....com>, 
	Amit Pundir <amit.pundir@...aro.org>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Caleb Connolly <caleb.connolly@...aro.org>, Praveenkumar Patil <PraveenKumar.Patil@....com>
Subject: Re: [PATCH] PCI/pwrctl: Decrease message about child OF nodes to debug

On Tue, Jul 2, 2024 at 7:33 PM <superm1@...nel.org> wrote:
>
> From: Mario Limonciello <mario.limonciello@....com>
>
> commit 8fb18619d910 ("PCI/pwrctl: Create platform devices for child OF
> nodes of the port node") introduced a new error message about populating
> OF nodes. This message isn't relevant on non-OF platforms, so downgrade
> it to debug instead.
>
> Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> Cc: Amit Pundir <amit.pundir@...aro.org>
> Cc: Neil Armstrong <neil.armstrong@...aro.org> # on SM8550-QRD, SM8650-QRD & SM8650-HDK
> Cc: Caleb Connolly <caleb.connolly@...aro.org> # OnePlus 8T
> Reported-by: Praveenkumar Patil <PraveenKumar.Patil@....com>
> Fixes: 8fb18619d910 ("PCI/pwrctl: Create platform devices for child OF nodes of the port node")
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
>  drivers/pci/bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
> index e4735428814d..f21c4ec979b5 100644
> --- a/drivers/pci/bus.c
> +++ b/drivers/pci/bus.c
> @@ -354,7 +354,7 @@ void pci_bus_add_device(struct pci_dev *dev)
>                 retval = of_platform_populate(dev->dev.of_node, NULL, NULL,
>                                               &dev->dev);
>                 if (retval)
> -                       pci_err(dev, "failed to populate child OF nodes (%d)\n",
> +                       pci_dbg(dev, "failed to populate child OF nodes (%d)\n",
>                                 retval);
>         }
>  }
> --
> 2.43.0
>
>

Ah! I was under the impression that of_platform_populate() would
return 0 with !OF but it returns -ENODEV instead...

Maybe do:

if (retval && retval != -ENODEV) and keep pci_err() here?

Bart