linux-kernel - Re: [RFC PATCH v14 0/8] TPEBS counting mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7chcdiHCBdwagj=zAeB3P1yT1Edc+q31Uq3LZfOFpP7vaQ@mail.gmail.com>
Date: Tue, 2 Jul 2024 11:59:11 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: "Wang, Weilin" <weilin.wang@...el.com>
Cc: Ian Rogers <irogers@...gle.com>, Arnaldo Carvalho de Melo <acme@...nel.org>, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	"Hunter, Adrian" <adrian.hunter@...el.com>, Kan Liang <kan.liang@...ux.intel.com>, 
	"linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Taylor, Perry" <perry.taylor@...el.com>, 
	"Alt, Samantha" <samantha.alt@...el.com>, "Biggers, Caleb" <caleb.biggers@...el.com>
Subject: Re: [RFC PATCH v14 0/8] TPEBS counting mode support

Hello Weilin,

On Mon, Jul 1, 2024 at 9:27 PM Wang, Weilin <weilin.wang@...el.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Wang, Weilin
> > Sent: Saturday, June 29, 2024 10:13 PM
> > To: Namhyung Kim <namhyung@...nel.org>
> > Cc: Ian Rogers <irogers@...gle.com>; Arnaldo Carvalho de Melo
> > <acme@...nel.org>; Peter Zijlstra <peterz@...radead.org>; Ingo Molnar
> > <mingo@...hat.com>; Alexander Shishkin
> > <alexander.shishkin@...ux.intel.com>; Jiri Olsa <jolsa@...nel.org>; Hunter,
> > Adrian <adrian.hunter@...el.com>; Kan Liang <kan.liang@...ux.intel.com>;
> > linux-perf-users@...r.kernel.org; linux-kernel@...r.kernel.org; Taylor, Perry
> > <perry.taylor@...el.com>; Alt, Samantha <samantha.alt@...el.com>; Biggers,
> > Caleb <caleb.biggers@...el.com>
> > Subject: RE: [RFC PATCH v14 0/8] TPEBS counting mode support
> >
> >
> >
> > > -----Original Message-----
> > > From: Namhyung Kim <namhyung@...nel.org>
> > > Sent: Thursday, June 27, 2024 1:32 PM
> > > To: Wang, Weilin <weilin.wang@...el.com>
> > > Cc: Ian Rogers <irogers@...gle.com>; Arnaldo Carvalho de Melo
> > > <acme@...nel.org>; Peter Zijlstra <peterz@...radead.org>; Ingo Molnar
> > > <mingo@...hat.com>; Alexander Shishkin
> > > <alexander.shishkin@...ux.intel.com>; Jiri Olsa <jolsa@...nel.org>; Hunter,
> > > Adrian <adrian.hunter@...el.com>; Kan Liang <kan.liang@...ux.intel.com>;
> > > linux-perf-users@...r.kernel.org; linux-kernel@...r.kernel.org; Taylor, Perry
> > > <perry.taylor@...el.com>; Alt, Samantha <samantha.alt@...el.com>;
> > Biggers,
> > > Caleb <caleb.biggers@...el.com>
> > > Subject: Re: [RFC PATCH v14 0/8] TPEBS counting mode support
> > >
> > > On Wed, Jun 26, 2024 at 06:17:22PM +0000, Wang, Weilin wrote:
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Namhyung Kim <namhyung@...nel.org>
> > > > > Sent: Wednesday, June 26, 2024 10:59 AM
> > > > > To: Wang, Weilin <weilin.wang@...el.com>
> > > > > Cc: Ian Rogers <irogers@...gle.com>; Arnaldo Carvalho de Melo
> > > > > <acme@...nel.org>; Peter Zijlstra <peterz@...radead.org>; Ingo Molnar
> > > > > <mingo@...hat.com>; Alexander Shishkin
> > > > > <alexander.shishkin@...ux.intel.com>; Jiri Olsa <jolsa@...nel.org>;
> > Hunter,
> > > > > Adrian <adrian.hunter@...el.com>; Kan Liang
> > <kan.liang@...ux.intel.com>;
> > > > > linux-perf-users@...r.kernel.org; linux-kernel@...r.kernel.org; Taylor,
> > > Perry
> > > > > <perry.taylor@...el.com>; Alt, Samantha <samantha.alt@...el.com>;
> > > Biggers,
> > > > > Caleb <caleb.biggers@...el.com>
> > > > > Subject: Re: [RFC PATCH v14 0/8] TPEBS counting mode support
> > > > >
> > > > > On Mon, Jun 24, 2024 at 06:20:16PM -0400, weilin.wang@...el.com
> > > wrote:
> > > > > > From: Weilin Wang <weilin.wang@...el.com>
> > > > > >
> > > > > > Changes in v14:
> > > > > >  - Fix the python import test failure. We cannot support PYTHON_PERF
> > > > > because it
> > > > > >  will trigger a chain of dependency issues if we add intel-tpebs.c to it.
> > So,
> > > > > >  only enable tpebs functions in evsel and evlist when PYTHON_PERF is
> > not
> > > > > >  defined.
> > > > >
> > > > > I think it's easier if we have Ian's python build cleanup first.
> > > > >
> > > > >   https://lore.kernel.org/linux-perf-users/20240625214117.953777-1-
> > > > > irogers@...gle.com
> > > > >
> > > > > Let me take a look at it..
> > > >
> > > > Ok, I will hold the cmd option name update until we conclude on this one.
> > > > Thanks a lot!
> > >
> > > Please take a look at the current perf-tools-next branch.
> >
> > Hi Namhyung,
> >
> > The python import test works correctly with the latest perf-tools-next branch
> > without the change I added in v14. I will send a new version that reverts this
> > change and update the command line option. Is there any other changes
> > you'd
> > like me to add?
>
> Hi Namhyung,
>
> I'm planning to submit the new version before Wednesday. Please let me know if
> you have any new comment on this.

Yep, I think it's ok unless it introduces new test failures.

Thanks,
Namhyung