linux-kernel - Re: [PATCH v3 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Wi-Fi device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0446de88-3b73-447f-96d2-4b8461defac2@broadcom.com>
Date: Tue, 2 Jul 2024 21:05:58 +0200
From: Arend van Spriel <arend.vanspriel@...adcom.com>
To: Jacobe Zang <jacobe.zang@...ion.com>, robh@...nel.org,
 krzk+dt@...nel.org, heiko@...ech.de, kvalo@...nel.org, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, conor+dt@...nel.org
Cc: efectn@...tonmail.com, dsimic@...jaro.org, jagan@...eble.ai,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 arend@...adcom.com, linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
 megi@....cz, duoming@....edu.cn, bhelgaas@...gle.com,
 minipli@...ecurity.net, brcm80211@...ts.linux.dev,
 brcm80211-dev-list.pdl@...adcom.com, nick@...das.com
Subject: Re: [PATCH v3 2/5] dt-bindings: net: wireless: brcm4329-fmac: add
 clock description for AP6275P Wi-Fi device

On 6/30/2024 9:36 AM, Jacobe Zang wrote:
> Add clocks and clock-names for brcm4329-fmac.

you can add my....

Reviewed-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Jacobe Zang <jacobe.zang@...ion.com>
> ---
>   .../bindings/net/wireless/brcm,bcm4329-fmac.yaml          | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index 2c2093c77ec9a..f542b60e44dc4 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -122,6 +122,14 @@ properties:
>         NVRAM. This would normally be filled in by the bootloader from platform
>         configuration data.
>   
> +  clocks:
> +    items:
> +      - description: Wi-Fi RTC clock

Having a few problems with the description. There is only one LPO clock 
input on the 43752 chipset. From the AMPAK AP6275P datasheet:

| 31 | LPO_IN | I | External Low Power Clock input (32.768KHz) |

I would suggest to use the description from the datasheet or something 
similar.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)