linux-kernel - Re: [PATCH v4 2/2] hwmon: add MP5920 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 2 Jul 2024 12:39:38 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Thomas Weißschuh <thomas@...ch.de>,
 Alex Vdovydchenko <xzeol@...oo.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Sean Anderson <sean.anderson@...ux.dev>,
 Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
 Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH v4 2/2] hwmon: add MP5920 driver

On 7/2/24 12:00, Thomas Weißschuh wrote:
> On 2024-07-02 14:52:51+0000, Alex Vdovydchenko wrote:
>> Add support for MPS Hot-Swap controller mp5920. This driver exposes
>> telemetry and limit value readings and writings.
>>
>> Signed-off-by: Alex Vdovydchenko <xzeol@...oo.com>
>> ---
>>   Documentation/hwmon/index.rst  |  1 +
>>   Documentation/hwmon/mp5920.rst | 91 +++++++++++++++++++++++++++++++++
>>   drivers/hwmon/pmbus/Kconfig    |  9 ++++
>>   drivers/hwmon/pmbus/Makefile   |  1 +
>>   drivers/hwmon/pmbus/mp5920.c   | 93 ++++++++++++++++++++++++++++++++++
>>   5 files changed, 195 insertions(+)
>>   create mode 100644 Documentation/hwmon/mp5920.rst
>>   create mode 100644 drivers/hwmon/pmbus/mp5920.c
> 
> The entry in MAINTAINERS seems to be missing.
> 

That isn't mandatory; checkpatch asks for it, but I prefer not to have it
in the first place if the submitter doesn't really plan to maintain it.

> Otherwise:
> 
> Reviewed-by: Thomas Weißschuh <linux@...ssschuh.net>
> 

Thanks,
Guenter