linux-kernel - Re: [PATCH v5 05/11] of: Add a KUnit test for overlays and test managed APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <051672a1de438842d4a9b20911ba9bfc.sboyd@kernel.org>
Date: Tue, 02 Jul 2024 14:45:58 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: David Gow <davidgow@...gle.com>
Cc: Michael Turquette <mturquette@...libre.com>, linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, patches@...ts.linux.dev, kunit-dev@...glegroups.com, linux-kselftest@...r.kernel.org, devicetree@...r.kernel.org, Brendan Higgins <brendan.higgins@...ux.dev>, Rae Moar <rmoar@...gle.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Rafael J . Wysocki <rafael@...nel.org>, Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>, Daniel Latypov <dlatypov@...gle.com>, Christian Marangi <ansuelsmth@...il.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Maxime Ripard <maxime@...no.tech>
Subject: Re: [PATCH v5 05/11] of: Add a KUnit test for overlays and test managed APIs

Quoting David Gow (2024-06-13 00:50:10)
> On Tue, 4 Jun 2024 at 06:38, Stephen Boyd <sboyd@...nel.org> wrote:
> >
> > Test the KUnit test managed overlay APIs. Confirm that platform devices
> > are created and destroyed properly. This provides us confidence that the
> > test managed APIs work correctly and can be relied upon to provide tests
> > with fake platform devices and device nodes via overlays compiled into
> > the kernel image.
> >
> > Cc: Rob Herring <robh@...nel.org>
> > Cc: Saravana Kannan <saravanak@...gle.com>
> > Cc: Daniel Latypov <dlatypov@...gle.com>
> > Cc: Brendan Higgins <brendan.higgins@...ux.dev>
> > Cc: David Gow <davidgow@...gle.com>
> > Cc: Rae Moar <rmoar@...gle.com>
> > Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> > Signed-off-by: Stephen Boyd <sboyd@...nel.org>
> > ---
> 
> This is looking good from my point of view, and passes on my test
> setup. One minor question (do we need both to select OF_OVERLAY and
> skip if it's not enabled?), but otherwise:

We don't need to skip if OF_OVERLAY isn't set because it's forced on for
the test. I'll remove it, thanks.