[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c4e4d913-2bdb-4451-be7d-0fee80ae0c66@intel.com>
Date: Tue, 2 Jul 2024 15:20:22 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>,
<shuah@...nel.org>, <fenghua.yu@...el.com>
CC: <linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
<ilpo.jarvinen@...ux.intel.com>, <tony.luck@...el.com>
Subject: Re: [PATCH v3 1/2] selftests/resctrl: Adjust effective L3 cache size
with SNC enabled
Hi Maciej,
On 7/1/24 7:18 AM, Maciej Wieczor-Retman wrote:
...
> +int snc_nodes_per_l3_cache(void)
> +{
> + int node_cpus, cache_cpus, i, ret = 1;
> +
> + node_cpus = count_sys_bitmap_bits("/sys/devices/system/node/node0/cpumap");
> + cache_cpus = count_sys_bitmap_bits("/sys/devices/system/cpu/cpu0/cache/index3/shared_cpu_map");
> +
> + if (!node_cpus || !cache_cpus) {
> + ksft_print_msg("Could not determine Sub-NUMA Cluster mode!\n");
nit: could you please check this series and remove exclamation marks from the messages
printed to user space? Just stating the error should be sufficient.
Reinette
Powered by blists - more mailing lists