linux-kernel - [PATCH v2] lib/build_OID_registry: Avoid non-destructive substitution for Perl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Wed,  3 Jul 2024 00:35:11 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Andrew Morton <akpm@...ux-foundation.org>,
	Nicolas Schier <nicolas@...sle.eu>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Paul Menzel <pmenzel@...gen.mpg.de>,
	Ahmad Fatoum <a.fatoum@...gutronix.de>,
	Masahiro Yamada <masahiroy@...nel.org>,
	kernel@...gutronix.de,
	it+linux-kconfig@...gen.mpg.de,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-kernel@...r.kernel.org
Subject: [PATCH v2] lib/build_OID_registry: Avoid non-destructive substitution for Perl < 5.13.2 compat

On a system with Perl 5.12.1, commit 5ef6dc08cfde
("lib/build_OID_registry: don't mention the full path of the script in
output") causes the build to fail with the error below.

     Bareword found where operator expected at ./lib/build_OID_registry line 41, near "s#^\Q$abs_srctree/\E##r"
     syntax error at ./lib/build_OID_registry line 41, near "s#^\Q$abs_srctree/\E##r"
     Execution of ./lib/build_OID_registry aborted due to compilation errors.
     make[3]: *** [lib/Makefile:352: lib/oid_registry_data.c] Error 255

Ahmad Fatoum analyzed that non-destructive substitution is only supported since
Perl 5.13.2. Instead of dropping `r` and having the side effect of modifying
`$0`, introduce a dedicated variable to support older Perl versions.

Fixes: 5ef6dc08cfde ("lib/build_OID_registry: don't mention the full path of the script in output")
Link: https://lore.kernel.org/all/259f7a87-2692-480e-9073-1c1c35b52f67@molgen.mpg.de/
Solution-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Nicolas Schier <nicolas@...sle.eu>
Cc: Masahiro Yamada <masahiroy@...nel.org>
Cc: kernel@...gutronix.de
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc: it+linux-kconfig@...gen.mpg.de
Cc: Stephen Rothwell <sfr@...b.auug.org.au>
Signed-off-by: Paul Menzel <pmenzel@...gen.mpg.de>
---
v2: Do not split Fixes tags over more than one line.

 lib/build_OID_registry | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/build_OID_registry b/lib/build_OID_registry
index 56d8bafeb848b..8267e8d71338b 100755
--- a/lib/build_OID_registry
+++ b/lib/build_OID_registry
@@ -38,7 +38,9 @@ close IN_FILE || die;
 #
 open C_FILE, ">$ARGV[1]" or die;
 print C_FILE "/*\n";
-print C_FILE " * Automatically generated by ", $0 =~ s#^\Q$abs_srctree/\E##r, ".  Do not edit\n";
+my $scriptname = $0;
+$scriptname =~ s#^\Q$abs_srctree/\E##;
+print C_FILE " * Automatically generated by ", $scriptname, ".  Do not edit\n";
 print C_FILE " */\n";
 
 #
-- 
2.40.1