linux-kernel - Re: [PATCH] perf pmu: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZoSSnBBXr5kb_zv3@google.com>
Date: Tue, 2 Jul 2024 16:51:56 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Chen Ni <nichen@...as.ac.cn>
Cc: peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
	mark.rutland@....com, alexander.shishkin@...ux.intel.com,
	jolsa@...nel.org, irogers@...gle.com, adrian.hunter@...el.com,
	kan.liang@...ux.intel.com, james.clark@....com,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf pmu: Remove unneeded semicolon

Hello,

On Mon, Jul 01, 2024 at 11:43:00AM +0800, Chen Ni wrote:
> Remove unneeded semicolon.
> This is detected by coccinelle.
> 
> Fixes: d9c5f5f94c2d ("perf pmu: Count sys and cpuid JSON events separately")
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>

Thanks for the fix but it's already fixed.

https://lore.kernel.org/linux-perf-users/20240628053049.44521-1-yang.lee@linux.alibaba.com/

Namhyung

> ---
>  tools/perf/util/pmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index c94a91645b21..884eb23445e4 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -1773,7 +1773,7 @@ size_t perf_pmu__num_events(struct perf_pmu *pmu)
>  	size_t nr;
>  
>  	pmu_aliases_parse(pmu);
> -	nr = pmu->sysfs_aliases + pmu->sys_json_aliases;;
> +	nr = pmu->sysfs_aliases + pmu->sys_json_aliases;
>  
>  	if (pmu->cpu_aliases_added)
>  		 nr += pmu->cpu_json_aliases;
> -- 
> 2.25.1
>