linux-kernel - Re:Re: [PATCH v4 2/3] bus: mhi: host: Add name for mhi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c4d4ef3.62f4.1907228f9a5.Coremail.slark_xiao@163.com>
Date: Tue, 2 Jul 2024 14:36:46 +0800 (CST)
From: "Slark Xiao" <slark_xiao@....com>
To: "Manivannan Sadhasivam" <manivannan.sadhasivam@...aro.org>
Cc: "Jeffrey Hugo" <quic_jhugo@...cinc.com>, loic.poulain@...aro.org, 
	ryazanov.s.a@...il.com, johannes@...solutions.net, 
	netdev@...r.kernel.org, mhi@...ts.linux.dev, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re:Re: [PATCH v4 2/3] bus: mhi: host: Add name for mhi_controller


At 2024-07-02 00:27:15, "Manivannan Sadhasivam" <manivannan.sadhasivam@...aro.org> wrote:
>On Mon, Jul 01, 2024 at 09:13:50AM -0600, Jeffrey Hugo wrote:
>> On 6/30/2024 8:12 PM, Slark Xiao wrote:
>> > For SDX72 MBIM mode, it starts data mux id from 112 instead of 0.
>> > This would lead to device can't ping outside successfully.
>> > Also MBIM side would report "bad packet session (112)".In order to
>> > fix this issue, we decide to use the device name of MHI controller
>> > to do a match in client driver side. Then client driver could set
>> > a corresponding mux_id value for this MHI product.
>> > 
>> > Signed-off-by: Slark Xiao <slark_xiao@....com>
>> > +++ b/include/linux/mhi.h
>> > @@ -289,6 +289,7 @@ struct mhi_controller_config {
>> >   };
>> >   /**
>> > + * @name: device name of the MHI controller
>> 
>> This needs to be below the next line
>> 
>
>If this is the only comment of the whole series, I will fix it up while
>applying. Otherwise, fix it while sending next revision.
>
>With that,
>
>Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>
>- Mani

Thanks for that^^
>
>> >    * struct mhi_controller - Master MHI controller structure
>> >    * @cntrl_dev: Pointer to the struct device of physical bus acting as the MHI
>> >    *            controller (required)
>> > @@ -367,6 +368,7 @@ struct mhi_controller_config {
>> >    * they can be populated depending on the usecase.
>> >    */
>> >   struct mhi_controller {
>> > +	const char *name;
>> >   	struct device *cntrl_dev;
>> >   	struct mhi_device *mhi_dev;
>> >   	struct dentry *debugfs_dentry;
>> 
>
>-- 
>மணிவண்ணன் சதாசிவம்