linux-kernel - Re: [PATCH] dma-buf: Remove unnecessary kmalloc() cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240702003357.6bfd1d918c56d536bb664c37@linux-foundation.org>
Date: Tue, 2 Jul 2024 00:33:57 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Christian König <christian.koenig@....com>
Cc: Christoph Hellwig <hch@....de>, Thorsten Blum
 <thorsten.blum@...lux.com>, jack@...e.cz, surenb@...gle.com,
 linux-kernel@...r.kernel.org, Sumit Semwal <sumit.semwal@...aro.org>,
 linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH] dma-buf: Remove unnecessary kmalloc() cast

On Tue, 2 Jul 2024 09:13:35 +0200 Christian König <christian.koenig@....com> wrote:

> yes that is 
> intentionally a define and not an inline function.
> 
> See this patch here which changed that:
> 
> commit 2c321f3f70bc284510598f712b702ce8d60c4d14
> Author: Suren Baghdasaryan <surenb@...gle.com>
> Date:   Sun Apr 14 19:07:31 2024 -0700
> 
>      mm: change inlined allocation helpers to account at the call site

Dang, yes, that was a regrettable change.  But hardly the end of the
world.  I do think each such alteration should have included a comment
to prevent people from going and cleaning them up.