linux-kernel - Re: [PATCH V3 1/2] soc: qcom: smp2p: Use devname for interrupt descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nrqojhdkt3ay5mtj6fcpmzqlo6xjo6rkvwymm673nn2b3tqqxj@4cjlba7j4o3p>
Date: Tue, 2 Jul 2024 10:59:21 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Sudeepgoud Patil <quic_sudeepgo@...cinc.com>
Cc: quic_bjorande@...cinc.com, andersson@...nel.org, quic_clew@...cinc.com, 
	mathieu.poirier@...aro.org, linux-kernel@...r.kernel.org, quic_deesin@...cinc.com, 
	linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org, 
	Konrad Dybcio <konrad.dybcio@...aro.org>
Subject: Re: [PATCH V3 1/2] soc: qcom: smp2p: Use devname for interrupt
 descriptions

On Thu, Jun 27, 2024 at 04:18:30PM GMT, Sudeepgoud Patil wrote:
> From: Chris Lew <quic_clew@...cinc.com>
> 
> When using /proc/interrupts to collect statistics on smp2p interrupt
> counts, it is hard to distinguish the different instances of smp2p from
> each other. For example to debug a processor boot issue, the ready and
> handover interrupts are checked for sanity to ensure the firmware
> reached a specific initialization stage.
> 
> Remove "smp2p" string from the irq request so that the irq will default
> to the device name. Add an .irq_print_chip() callback to print the irq
> chip name as the device name. These two changes allow for a unique name
> to be used in /proc/interrupts as shown below.
> 
> / # cat /proc/interrupts | grep smp2p
>  18:  ...      ipcc 196610 Edge      smp2p-adsp
>  20:  ...      ipcc 131074 Edge      smp2p-modem
> 170:  ...  smp2p-modem   1 Edge      q6v5 ready
> 178:  ...  smp2p-adsp   1 Edge      q6v5 ready
> 
> Signed-off-by: Chris Lew <quic_clew@...cinc.com>

Your sign-off is missing. LGTM otherwise

> ---
>  drivers/soc/qcom/smp2p.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 

> 

-- 
With best wishes
Dmitry