linux-kernel - Re: [PATCH v2 03/10] dt-bindings: riscv: add SpacemiT K1 bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240702094235.GA2506224@ofsar>
Date: Tue, 2 Jul 2024 09:42:35 +0000
From: Yixun Lan <dlan@...too.org>
To: Conor Dooley <conor@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Samuel Holland <samuel.holland@...ive.com>,
	Anup Patel <anup@...infault.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>, Lubomir Rintel <lkundrak@...sk>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Palmer Dabbelt <palmer@...ive.com>, linux-riscv@...ts.infradead.org,
	linux-serial@...r.kernel.org, Inochi Amaoto <inochiama@...look.com>,
	Meng Zhang <zhangmeng.kevin@...cemit.com>,
	Yangyu Chen <cyy@...self.name>
Subject: Re: [PATCH v2 03/10] dt-bindings: riscv: add SpacemiT K1 bindings

Hi

On 13:24 Mon 01 Jul     , Conor Dooley wrote:
> On Thu, Jun 27, 2024 at 03:31:17PM +0000, Yixun Lan wrote:
> > From: Yangyu Chen <cyy@...self.name>
> > 
> > Add DT binding documentation for the SpacemiT K1 Soc[1] and the Banana
> > Pi BPi-F3 board[2] which used it.
> > 
> > [1] https://www.spacemit.com/en/spacemit-key-stone-2/
> > [2] https://docs.banana-pi.org/en/BPI-F3/BananaPi_BPI-F3
> > 
> 
> Please make these link tags when you resend, like
> 
> Link: https://foo [1]
> 
> and don't leave blank lines between them and the signoff.
> 
sure, will fix in v3

> > Signed-off-by: Yangyu Chen <cyy@...self.name>
> > Signed-off-by: Yixun Lan <dlan@...too.org>
> > ---
> >  .../devicetree/bindings/riscv/spacemit.yaml        | 24 ++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/riscv/spacemit.yaml b/Documentation/devicetree/bindings/riscv/spacemit.yaml
> > new file mode 100644
> > index 0000000000000..3b151fd02473e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/riscv/spacemit.yaml
> > @@ -0,0 +1,24 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/riscv/spacemit.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: SpacemiT SoC-based boards
> > +
> > +description:
> > +  SpacemiT SoC-based boards
> 
> Please work out who is gonna maintain these SoCs and add that here to
> resolve the bot's report.
> 
sure, talked to Yangyu, will also add him as maintainer
this should fix bot's complaint..

btw, thanks for all your other comments in the whole thread, will fix them all
> Thanls,
> Conor.
> 
> > +
> > +properties:
> > +  $nodename:
> > +    const: '/'
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - bananapi,bpi-f3
> > +          - const: spacemit,k1
> > +
> > +additionalProperties: true
> > +
> > +...
> > 
> > -- 
> > 2.45.2
> > 



-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55