linux-kernel - Re: [PATCH] HID: apple: Add support for magic keyboard backlight on T2 Macs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB0217895AB52142877C726851B8DC2@MA0P287MB0217.INDP287.PROD.OUTLOOK.COM>
Date: Tue, 2 Jul 2024 09:50:09 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Orlando Chamberlain <orlandoch.dev@...il.com>
CC: Jiri Kosina <jikos@...nel.org>, "bentiss@...nel.org" <bentiss@...nel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, Linux Kernel
 Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: apple: Add support for magic keyboard backlight on
 T2 Macs

Hi Orlando

I resubmitted the patch which included only the backlight driver had no replies. Let's see if jiri is fine with the separate driver or not.

> On 2 Jul 2024, at 4:27 AM, Orlando Chamberlain <orlandoch.dev@...il.com> wrote:
> 
> 
> 
>>> On 2 Jul 2024, at 8:48 AM, Orlando Chamberlain <orlandoch.dev@...il.com> wrote:
>>> 
>>>> On 2 Jul 2024, at 4:19 AM, Aditya Garg <gargaditya08@...e.com> wrote:
>>> Apparently this patch is breaking touchbar functionality is some cases.
>> 
>> I think this is because apple_magic_backlight_init will return an error when it finds the touchbar interface, but this return value is not checked, so hid-apple still binds to the touchbar backlight.
> 
> We may also need to make sure hid_hw_stop is called in this case. Perhaps we can move this logic from apple_magic_backlight_init to apple_probe?
> 
>> 
>> This should be fixable so I don't think we need to still have the separate driver.
>> 
>>>> 
>>>> static int apple_probe(struct hid_device *hdev,
>>>>     const struct hid_device_id *id)
>>>> {
>>>> @@ -860,6 +940,9 @@ static int apple_probe(struct hid_device *hdev,
>>>> if (quirks & APPLE_BACKLIGHT_CTL)
>>>>     apple_backlight_init(hdev);
>>>> 
>>>> +    if (quirks & APPLE_MAGIC_BACKLIGHT)
>>>> +        apple_magic_backlight_init(hdev);
>> 
>> return value isn't checked here ^, we return 0 unconditionally below.
>> 
>>>> +
>>>> return 0;
>>>> }