linux-kernel - Re: [PATCH] drm/stm: Remove unnecessary .owner for lvds_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b33d9470-b845-478f-97d3-636e158693d2@foss.st.com>
Date: Tue, 2 Jul 2024 12:00:35 +0200
From: Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        <yannick.fertre@...s.st.com>
CC: <philippe.cornu@...s.st.com>, <maarten.lankhorst@...ux.intel.com>,
        <mripard@...nel.org>, <tzimmermann@...e.de>, <airlied@...il.com>,
        <daniel@...ll.ch>, <mcoquelin.stm32@...il.com>,
        <alexandre.torgue@...s.st.com>, <dri-devel@...ts.freedesktop.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        Abaci
 Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] drm/stm: Remove unnecessary .owner for
 lvds_platform_driver

Hi Jiapeng,

On 7/1/24 08:23, Jiapeng Chong wrote:
> Remove .owner field if calls are used which set it automatically.
>
> ./drivers/gpu/drm/stm/lvds.c:1213:3-8: No need to set .owner here. The core will do it.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9457
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/gpu/drm/stm/lvds.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/lvds.c b/drivers/gpu/drm/stm/lvds.c
> index 2fa2c81784e9..06f2d7a56cc9 100644
> --- a/drivers/gpu/drm/stm/lvds.c
> +++ b/drivers/gpu/drm/stm/lvds.c
> @@ -1210,7 +1210,6 @@ static struct platform_driver lvds_platform_driver = {
>  	.remove = lvds_remove,
>  	.driver = {
>  		.name = "stm32-display-lvds",
> -		.owner = THIS_MODULE,
>  		.of_match_table = lvds_dt_ids,
>  	},
>  };


Indeed, platform_driver_register() overrides the value of the owner.

Acked-by: Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>

Thanks,
Raphaël