linux-kernel - Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: Fix packet still tx after gate close by reducing i226 MAC retry buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26d42742-d9bd-4817-8a08-94b12598fe4c@linux.intel.com>
Date: Tue, 2 Jul 2024 10:28:54 +0800
From: "Abdul Rahim, Faizal" <faizal.abdul.rahim@...ux.intel.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Jesse Brandeburg <jesse.brandeburg@...el.com>,
 Tony Nguyen <anthony.l.nguyen@...el.com>,
 Vinicius Costa Gomes <vinicius.gomes@...el.com>, netdev@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: Fix packet still tx
 after gate close by reducing i226 MAC retry buffer

On 1/7/2024 8:42 pm, Paul Menzel wrote:
> Dear Faizal,
> 
> 
> Thank you for your patch.
> 
>> This follows guidelines from:
>>
>> a) Ethernet Controller I225/I22 Spec Update Rev 2.1 Errata Item 9:
>>     TSN: Packet Transmission Might Cross Qbv Window
>> b) I225/6 SW User Manual Rev 1.2.4: Section 8.11.5 Retry Buffer Control
>>
>> Test Steps:
>> 1. Send taprio cmd to board A
>> tc qdisc replace dev enp1s0 parent root handle 100 taprio \
>> num_tc 4 \
>> map 3 2 1 0 3 3 3 3 3 3 3 3 3 3 3 3 \
>> queues 1@0 1@1 1@2 1@3 \
>> base-time 0 \
>> sched-entry S 0x07 500000 \
>> sched-entry S 0x0f 500000 \
>> flags 0x2 \
>> txtime-delay 0
>>
>> - Note that for TC3, gate opens for 500us and close for another 500us
>>
>> 3. Take tcpdump log on Board B
>>
>> 4. Send udp packets via UDP tai app from Board A to Board B
>>
>> 5. Analyze tcpdump log via wireshark log on Board B
>> - Observed that the total time from the first to the last packet
>> received during one cycle for TC3 does not exceed 500us
> 
> Indent the list item by four spaces? (Also above?)

Hi Paul,

Would like to confirm, the indent suggestion from you is referring to which 
style ?

(a)
1.  Send taprio ...
     tc qdisc  ..
     map 3 4 ..
     queue 1@0 ....

(b)
1. Send taprio ...
     tc qdisc  ..
     map 3 4 ..
     queue 1@0 ....

(c)
     1. Send taprio ...
        tc qdisc  ..
        map 3 4 ..
        queue 1@0 ....

I think it's (a), but afraid if misunderstood the suggestion.
Thank you !

Regards,
Faizal