linux-kernel - Re: [PATCH] ARM: dts: microchip: at91: align LED node name with bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7cc46dc-8ce6-45d5-a320-63fdce4967f9@linaro.org>
Date: Tue, 2 Jul 2024 12:31:13 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Nicolas Ferre <nicolas.ferre@...rochip.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: microchip: at91: align LED node name with
 bindings

On 02/07/2024 10:51, Alexander Dahl wrote:
>> diff --git a/arch/arm/boot/dts/microchip/at91sam9x5cm.dtsi b/arch/arm/boot/dts/microchip/at91sam9x5cm.dtsi
>> index cdd37f67280b..fb3c19bdfcb6 100644
>> --- a/arch/arm/boot/dts/microchip/at91sam9x5cm.dtsi
>> +++ b/arch/arm/boot/dts/microchip/at91sam9x5cm.dtsi
>> @@ -120,13 +120,13 @@ rootfs@...000 {
>>  	leds {
>>  		compatible = "gpio-leds";
>>  
>> -		pb18 {
>> +		led-pb18 {
>>  			label = "pb18";
>>  			gpios = <&pioB 18 GPIO_ACTIVE_LOW>;
>>  			linux,default-trigger = "heartbeat";
>>  		};
>>  
>> -		pd21 {
>> +		led-pd21 {
>>  			label = "pd21";
>>  			gpios = <&pioD 21 GPIO_ACTIVE_HIGH>;
>>  		};
> 
> In this case these are all gpio-leds and the pattern is in the
> leds-gpio gpio binding.  I'm wondering however why you chose the very
> generic 'led' match over the more strict one requiring the names to

match? Which match? I did not write the match pattern in the binding, did I?

> look like 'led-0', 'led-1' an so forth?  The generic match would also

Works for me too. The easiest was to add led prefix. I am not the
maintainer of this platform, so I am doing just some random cleanups and
prefix is the easiest cleanup.

> match names like 'knowledge' or 'controlled'.  But besides that:

Best regards,
Krzysztof