linux-kernel - Re: [PATCH] arm64: dts: qcom: sm8550-hdk: add the Wifi node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ba07bbf-e8b1-4244-882b-ff2575368b20@kernel.org>
Date: Tue, 2 Jul 2024 12:42:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Amit Pundir <amit.pundir@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 linux-arm-msm <linux-arm-msm@...r.kernel.org>,
 dt <devicetree@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sm8550-hdk: add the Wifi node

On 02/07/2024 11:16, Amit Pundir wrote:
> Describe the ath12k WLAN on-board the WCN7850 module present on the
> board.
> 
> Signed-off-by: Amit Pundir <amit.pundir@...aro.org>
> ---
> Kanged verbatim from 490812872449 ("arm64: dts: qcom: sm8550-qrd: add the Wifi node").
> 
>  arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 97 +++++++++++++++++++++++++
>  1 file changed, 97 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> index 12d60a0ee095..c453d081a2df 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> @@ -279,6 +279,68 @@ platform {
>  			};
>  		};
>  	};
> +
> +	wcn7850-pmu {
> +		compatible = "qcom,wcn7850-pmu";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&wlan_en>, <&pmk8550_sleep_clk>;
> +
> +		wlan-enable-gpios = <&tlmm 80 GPIO_ACTIVE_HIGH>;
> +		/*
> +		 * TODO Add bt-enable-gpios once the Bluetooth driver is
> +		 * converted to using the power sequencer.

I don't understand why hardware description should depend on the driver.
Either you have this GPIO or not. If you have it, what does it matter if
there is no driver who can play with it?

Best regards,
Krzysztof