linux-kernel - Re: [PATCH] fs/ntfs3: Fix memory corruption when page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b41e693f-940b-42a8-8154-1721c7ff13e1@paragon-software.com>
Date: Tue, 2 Jul 2024 14:41:23 +0300
From: Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To: Linux regressions mailing list <regressions@...ts.linux.dev>
CC: popcorn mix <popcornmix@...il.com>, <ntfs3@...ts.linux.dev>, Linux-fsdevel
	<linux-fsdevel@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs/ntfs3: Fix memory corruption when page_size changes


On 01.07.2024 15:53, Linux regression tracking (Thorsten Leemhuis) wrote:
> [CCing a few lists]
>
> Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
> for once, to make this easily accessible to everyone.
>
> Konstantin, what's the status of this regression report or the patch Dom
> Cobley propsed to fix the issue? From here it looks like it fall through
> the cracks, but I might be missing something.
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
> #regzbot poke
>
> On 14.06.24 18:24, popcorn mix wrote:
>> On Fri, Jun 14, 2024 at 4:55 PM Dom Cobley <popcornmix@...il.com> wrote:
>>> The kernel panic can be observed when connecting an
>>> ntfs formatted drive that has previously been connected
>>> to a Windows machine to a Raspberry Pi 5, which by defauilt
>>> uses a 16K kernel pagesize.
>> Here are links to some bug reports about the issue:
>> https://github.com/raspberrypi/linux/issues/6036
>> https://forum.libreelec.tv/thread/28620-libreelec-12-0-rpi5-and-ntfs-hdd-problem/?postID=192713#post192713
>> https://forums.raspberrypi.com/viewtopic.php?p=2203090#p2203090
>> https://forums.raspberrypi.com/viewtopic.php?t=367545
>>
>> The common points are it occurs on the (default) 16K pagesize kernel,
>> but switching to 4K pagesize kernel
>> avoids the issue.
>>
>> Issue wasn't present in previous RPiOS LTS kernel (6.1), but is
>> present in current LTS kernel (6.6).
>> Revering to 6.1 kernel avoids the issue.
>>
>> I've confirmed that reverting the commit:
>> 865e7a7700d9 ("fs/ntfs3: Reduce stack usage")
>>
>> avoids the issue.
>>
>> This patch avoids the issue for me, and I'd like confirmation it is correct.
Hello everyone,

I recently accepted this patch with the same fix:
https://lore.kernel.org/ntfs3/20240529064053.2741996-2-chenhuacai@loongson.cn/.

Unfortunately, I don't have an RPi with a pagesize=16K at hand, so I 
can't practically test it.

Regards, Konstantin