linux-kernel - Re: [PATCH] libfdt: check return value of fdt_num_mem_rsv() in fdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b083a48-5e56-493a-b235-60afaf794fd7@web.de>
Date: Tue, 2 Jul 2024 14:54:06 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Heinrich Schuchardt <heinrich.schuchardt@...onical.com>,
 devicetree@...r.kernel.org, Rob Herring <robh@...nel.org>,
 Saravana Kannan <saravanak@...gle.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] libfdt: check return value of fdt_num_mem_rsv() in
 fdt_pack()

> fdt_num_mem_rsv() may return -FDT_ERR_TRUNCATED.
> In this case fdt_pack() should propagate the error code.

1. Please choose imperative wordings for an improved change description.
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n94

2. Would you like to add any tags (like “Fixes” and “Cc”)?

3. How do you think about to use a summary phrase like “Complete error handling
   in fdt_pack()”?

Regards,
Markus