linux-kernel - Re: [PATCH net-next v5 2/7] netlink: specs: Expand the PSE netlink command with C33 new features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ee273f0647d00ee23f964e3f3f4a216c8413b84.camel@redhat.com>
Date: Tue, 02 Jul 2024 15:19:39 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kory Maincent <kory.maincent@...tlin.com>, "David S. Miller"
	 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	 <kuba@...nel.org>, Donald Hunter <donald.hunter@...il.com>, Oleksij Rempel
	 <o.rempel@...gutronix.de>, Jonathan Corbet <corbet@....net>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Dent Project
	 <dentproject@...uxfoundation.org>, kernel@...gutronix.de, 
	linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next v5 2/7] netlink: specs: Expand the PSE netlink
 command with C33 new features

On Fri, 2024-06-28 at 10:31 +0200, Kory Maincent wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@...tlin.com>
> 
> Expand the c33 PSE attributes with PSE class, extended state information
> and power consumption.
> 
> ./ynl/cli.py --spec netlink/specs/ethtool.yaml --no-schema --do pse-get
> 	     --json '{"header":{"dev-name":"eth0"}}'
> {'c33-pse-actual-pw': 1700,
>  'c33-pse-admin-state': 3,
>  'c33-pse-pw-class': 4,
>  'c33-pse-pw-d-status': 4,
>  'header': {'dev-index': 4, 'dev-name': 'eth0'}}
> 
> ./ynl/cli.py --spec netlink/specs/ethtool.yaml --no-schema --do pse-get
> 	     --json '{"header":{"dev-name":"eth0"}}'
> {'c33-pse-admin-state': 3,
>  'c33-pse-ext-state': 'mr-mps-valid',
>  'c33-pse-ext-substate': 2,
>  'c33-pse-pw-d-status': 2,
>  'header': {'dev-index': 4, 'dev-name': 'eth0'}}
> 
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>

This does not apply cleanly to net-next due to commit 46fb3ba95b93
("ethtool: Add an interface for flashing transceiver modules'
firmware").

Please rebase and re-submit.

Also it would be great if you could add some documentation to the new
attributes.

Thanks,

Paolo