linux-kernel - Re: [PATCH wireless 0/9] wifi: cfg80211: avoid some garbage values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOiHx=n5rfCBkO8wfqpa=UgL==Ty9=s1f=roVHiaFy2acQOHtw@mail.gmail.com>
Date: Tue, 2 Jul 2024 16:02:25 +0200
From: Jonas Gorski <jonas.gorski@...il.com>
To: Su Hui <suhui@...china.com>
Cc: arend.vanspriel@...adcom.com, kvalo@...nel.org, johannes.berg@...el.com, 
	kees@...nel.org, a@...repo.ru, quic_alokad@...cinc.com, zyytlz.wz@....com, 
	marcan@...can.st, petr.tesarik.ext@...wei.com, duoming@....edu.cn, 
	colin.i.king@...il.com, u.kleine-koenig@...gutronix.de, 
	quic_jjohnson@...cinc.com, linville@...driver.com, pieterpg@...adcom.com, 
	meuleman@...adcom.com, frankyl@...adcom.com, stanley.hsu@...ress.com, 
	wright.feng@...ress.com, ian.lin@...ineon.com, chi-hsien.lin@...ress.com, 
	zajec5@...il.com, antonio@...n-mesh.com, franky.lin@...adcom.com, 
	linux-wireless@...r.kernel.org, brcm80211@...ts.linux.dev, 
	brcm80211-dev-list.pdl@...adcom.com, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH wireless 0/9] wifi: cfg80211: avoid some garbage values

Hi,

On Tue, 2 Jul 2024 at 14:50, Su Hui <suhui@...china.com> wrote:
>
> Clang static checker (scan-build) has some warnings as follows.
>
> included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c:16
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h:123:2:
> warning:Assigned value is garbage or undefined [core.uninitialized.Assign]
>   123 |         __le32 data_le = cpu_to_le32(*data);
>       |         ^~~~~~~~~~~~~~   ~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c:138:3:warning
> Value stored to 'err' is never read [deadcode.DeadStores]
>
> There are some functions like brcmf_fil_{cmd,iovar,basscfg}_int_get()
> which read the value of its parameter, but some callers have not
> initialized these parameters which will be read. And this patchset fixes
> these problems.

The core issue here seems to be that
brcmf_fil_{cmd,iovar,basscfg}_int_get() function (needlessly?) read
from *data.

So instead of forcing all callers of
brcmf_fil_{cmd,iovar,basscfg}_int_get() to initialize *data first, I
suggest changing brcmf_fil_{cmd,iovar,basscfg}_int_get() to just not
read from it.

I see no reason why they should care about what the previous value
was, since they are supposed to overwrite it anyway.

Best Regards,
Jonas