linux-kernel - [PATCH v1 4/5] devres: Simplify devm_percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1719931914-19035-5-git-send-email-quic_zijuhu@quicinc.com>
Date: Tue, 2 Jul 2024 22:51:53 +0800
From: Zijun Hu <quic_zijuhu@...cinc.com>
To: <linux-kernel@...r.kernel.org>
CC: <gregkh@...uxfoundation.org>, <rafael@...nel.org>, <brgl@...ev.pl>,
        <madalin.bucur@....com>, <davem@...emloft.net>,
        <andriy.shevchenko@...ux.intel.com>,
        Zijun Hu <quic_zijuhu@...cinc.com>
Subject: [PATCH v1 4/5] devres: Simplify devm_percpu_match() implementation

Simplify devm_percpu_match() implementation by removing redundant
conversions.

Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
---
Previous discussion link:
https://lore.kernel.org/lkml/1719496036-24642-1-git-send-email-quic_zijuhu@quicinc.com/

Changes since the original one:
 - Select the simplier solution

 drivers/base/devres.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/base/devres.c b/drivers/base/devres.c
index e9b0d94aeabd..2ad6dacb3472 100644
--- a/drivers/base/devres.c
+++ b/drivers/base/devres.c
@@ -1176,9 +1176,8 @@ static void devm_percpu_release(struct device *dev, void *pdata)
 
 static int devm_percpu_match(struct device *dev, void *data, void *p)
 {
-	struct devres *devr = container_of(data, struct devres, data);
-
-	return *(void **)devr->data == p;
+	/* @data is already and must be (void *)devr->data */
+	return *(void **)data == p;
 }
 
 /**
-- 
2.34.1