linux-kernel - Re: [PATCH v2 1/3] dt-bindings: display: himax-hx8394: Add Microchip AC40T08A MIPI Display panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 2 Jul 2024 16:03:56 +0100
From: Conor Dooley <conor@...nel.org>
To: Manikandan.M@...rochip.com
Cc: megi@....cz, javierm@...hat.com, neil.armstrong@...aro.org,
	quic_jesszhan@...cinc.com, sam@...nborg.org, airlied@...il.com,
	daniel@...ll.ch, maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org, tzimmermann@...e.de, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org,
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: display: himax-hx8394: Add Microchip
 AC40T08A MIPI Display panel

On Tue, Jul 02, 2024 at 04:47:39AM +0000, Manikandan.M@...rochip.com wrote:
> Hi Conor,
> 
> On 01/07/24 3:33 pm, Conor Dooley wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > 
> > ForwardedMessage.eml
> > 
> > Subject:
> > Re: [PATCH v2 1/3] dt-bindings: display: himax-hx8394: Add Microchip 
> > AC40T08A MIPI Display panel
> > From:
> > Conor Dooley <conor@...nel.org>
> > Date:
> > 01/07/24, 3:33 pm
> > 
> > To:
> > Manikandan Muralidharan <manikandan.m@...rochip.com>
> > CC:
> > megi@....cz, javierm@...hat.com, neil.armstrong@...aro.org, 
> > quic_jesszhan@...cinc.com, sam@...nborg.org, airlied@...il.com, 
> > daniel@...ll.ch, maarten.lankhorst@...ux.intel.com, mripard@...nel.org, 
> > tzimmermann@...e.de, robh@...nel.org, krzk+dt@...nel.org, 
> > conor+dt@...nel.org, dri-devel@...ts.freedesktop.org, 
> > devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
> > 
> > 

btw, please fix your mail client :/

> > On Mon, Jul 01, 2024 at 02:28:35PM +0530, Manikandan Muralidharan wrote:
> >> Add compatible string for the Microchip's AC40T08A MIPI Display
> >> panel.This panel uses a Himax HX8394 display controller.
> >> The reset line is not populated and leads to driver probe issues,
> >> thus add conditional block to narrow reset-gpio property per variant.
> > I really should have asked on v1, but I wasn't sure whether or not the
> > optional nature of the reset-gpios was specific to your new panel so I
> > held off: Is it ever the case that a reset-gpio can be provided for this
> > microchip panel, or just not in the configuration you tested? If it is
> > never possible, then I'd probably do...
> The reset-gpio line can be provided for the microchip MIPI panel, the 
> SoC variant in which I tested did not have the reset line configured, 
> hence had to make it optional here and also in the driver to avoid panel 
> probe issues.

Okay, then:
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)