linux-kernel - Re: [PATCH wireless 1/9] wifi: cfg80211: avoid garbage value of 'io_type' in brcmf_cfg80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19073fcc9e8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
Date: Tue, 02 Jul 2024 17:07:45 +0200
From: Arend Van Spriel <arend.vanspriel@...adcom.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Su Hui <suhui@...china.com>
CC: <kvalo@...nel.org>, <johannes.berg@...el.com>, <kees@...nel.org>, <a@...repo.ru>, <marcan@...can.st>, <quic_alokad@...cinc.com>, <zyytlz.wz@....com>, <petr.tesarik.ext@...wei.com>, <duoming@....edu.cn>, <colin.i.king@...il.com>, <frankyl@...adcom.com>, <meuleman@...adcom.com>, <phaber@...adcom.com>, <linville@...driver.com>, <linux-wireless@...r.kernel.org>, <brcm80211@...ts.linux.dev>, <brcm80211-dev-list.pdl@...adcom.com>, <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH wireless 1/9]  wifi: cfg80211: avoid garbage value of 'io_type' in  brcmf_cfg80211_attach()

On July 2, 2024 3:57:27 PM Dan Carpenter <dan.carpenter@...aro.org> wrote:

> On Tue, Jul 02, 2024 at 08:24:44PM +0800, Su Hui wrote:
>> brcmf_fil_cmd_int_get() reads the value of 'io_type' and passes it to
>> brcmf_fil_cmd_data_get(). Initialize 'io_type' to avoid garbage value.
>
> Since you're going to be resending anyway, please delete the space char
> from the start of the line.
>
> It's weird that brcmf_fil_cmd_data_get() uses the uninitialized data.
> It looks like it just goes to great lengths to preserve the original
> data in io_type...  So it likely is harmless enough but still a strange
> and complicated way write a no-op.

Not sure if it helps, but I tried to explain the reason in response to 
patch 0 (cover letter).

Regards,
Arend




Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)