[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240702154216.GA1037@lst.de>
Date: Tue, 2 Jul 2024 17:42:16 +0200
From: Christoph Hellwig <hch@....de>
To: "Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>
Cc: Christoph Hellwig <hch@....de>, david@...morbit.com,
willy@...radead.org, chandan.babu@...cle.com, djwong@...nel.org,
brauner@...nel.org, akpm@...ux-foundation.org,
linux-kernel@...r.kernel.org, yang@...amperecomputing.com,
linux-mm@...ck.org, john.g.garry@...cle.com,
linux-fsdevel@...r.kernel.org, hare@...e.de, p.raghav@...sung.com,
mcgrof@...nel.org, gost.dev@...sung.com, cl@...amperecomputing.com,
linux-xfs@...r.kernel.org, Zi Yan <zi.yan@...t.com>
Subject: Re: [PATCH v8 06/10] iomap: fix iomap_dio_zero() for fs bs >
system page size
On Tue, Jul 02, 2024 at 02:01:23PM +0000, Pankaj Raghav (Samsung) wrote:
+static int iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio,
> loff_t pos, unsigned len)
> {
> struct inode *inode = file_inode(dio->iocb->ki_filp);
> struct bio *bio;
>
> + if (!len)
> + return 0;
> /*
> * Max block size supported is 64k
> */
> - WARN_ON_ONCE(len > ZERO_PAGE_64K_SIZE);
> + if (len > ZERO_PAGE_64K_SIZE)
> + return -EINVAL;
The should probably be both WARN_ON_ONCE in addition to the error
return (and ZERO_PAGE_64K_SIZE really needs to go away..)
> + ret = iomap_dio_zero(iter, dio, pos, fs_block_size - pad);
Overly lone line here.
Otherwise this looks good.
Powered by blists - more mailing lists