linux-kernel - Re: [PATCH bpf-next] bpftool: Mount bpffs when pinmaps path not under the bpffs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a095e65d-fdde-4bb4-832a-daa8ea999f2d@kernel.org>
Date: Tue, 2 Jul 2024 17:05:06 +0100
From: Quentin Monnet <qmo@...nel.org>
To: Tao Chen <chen.dylane@...il.com>
Cc: Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>,
 bpf@...r.kernel.org, Martin KaFai Lau <martin.lau@...ux.dev>,
 Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
 Yonghong Song <yonghong.song@...ux.dev>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpftool: Mount bpffs when pinmaps path not under
 the bpffs

On 02/07/2024 14:11, Tao Chen wrote:
> As qmonnet said [1], map pinning will fail if the pinmaps path not under
> the bpffs, like:
> libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS
> Error: failed to pin all maps
> [1]: https://github.com/libbpf/bpftool/issues/146
> 
> Fixes: 3767a94b3253 ("bpftool: add pinmaps argument to the load/loadall")
> Signed-off-by: Tao Chen <chen.dylane@...il.com>

The patch looks good, thank you!

Tested-by: Quentin Monnet <qmo@...nel.org>
Reviewed-by: Quentin Monnet <qmo@...nel.org>