linux-kernel - Re: [PATCH v2] filemap: add trace events for get_pages, map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240702123747.796b98c5@rorschach.local.home>
Date: Tue, 2 Jul 2024 12:37:47 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Takaya Saeki <takayas@...omium.org>
Cc: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>, Matthew Wilcox
 <willy@...radead.org>, Andrew Morton <akpm@...ux-foundation.org>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Junichi Uekawa
 <uekawa@...omium.org>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-mm@...ck.org
Subject: Re: [PATCH v2] filemap: add trace events for get_pages, map_pages,
 and fault

On Tue, 2 Jul 2024 19:27:16 +0900
Takaya Saeki <takayas@...omium.org> wrote:

> Hello all, and thank you so much for the review, Steven and Masami.
> 
> I'm currently considering replacing the `max_ofs` output with
> `length`. Please let me know your thoughts.
> With the current design, a memory range of an event is an inclusive
> range of [ofs, max_ofs + 4096]. I found the `+4096` part confusing
> during the ureadahead's upstreaming work. Replacing `max_ofs` with
> `length` makes the range specified by an event much more concise.

This makes sense to me.

Matthew, have any comments on this?

Thanks,

-- Steve